Skip to content

Commit 585222e

Browse files
committed
Small bug fix - Incorrect setting name & UI control leak though
1 parent 2a14fae commit 585222e

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

applications/Setting/Setting.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ void Setting::Setup()
2727
AddUIComponent(new UIButton("Device Serial", Color(0x00FF30), []() -> void {MatrixOS::UIInterface::TextScroll(Device::GetSerial(), Color(0x00FFFF));}), Point(3, Device::y_size - 1));
2828

2929

30-
AddUIComponent(new UIButton("Device ID", Color(0x00FFFF), []() -> void {MatrixOS::UserVar::device_id = MatrixOS::UIInterface::NumberSelector8x8(MatrixOS::UserVar::device_id, 0x00FFFF, "Keypad High Threshold", 0, 255);}), Point(Device::x_size - 1, Device::y_size - 1));
30+
AddUIComponent(new UIButton("Device ID", Color(0x00FFFF), []() -> void {MatrixOS::UserVar::device_id = MatrixOS::UIInterface::NumberSelector8x8(MatrixOS::UserVar::device_id, 0x00FFFF, "Device ID", 0, 255);}), Point(Device::x_size - 1, Device::y_size - 1));
3131

3232
// //Velocity Sensitive
3333
AddUIComponent(new UIButtonDimmable("Velocity Sensitive",

os/ui/component/UINumModifier.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@ class UINumberModifier: public UIComponent
5252
}
5353

5454
*value = (int32_t)new_value;
55-
return true;
5655
}
57-
return false;
56+
return true; //Prevent leak though to cause UI text scroll
5857
}
5958
};

0 commit comments

Comments
 (0)