From 4418a15faeeab1811333068b9a5433ce276025ad Mon Sep 17 00:00:00 2001 From: Polymeta <40173118+Polymeta@users.noreply.github.com> Date: Sun, 26 Jan 2025 01:53:29 +0000 Subject: [PATCH 1/2] re-introduce linting to ui package and run linter --- packages/ui/eslint.config.mjs | 12 ++++++++ packages/ui/package.json | 4 ++- .../ui/src/components/ForgeActionButton.vue | 4 +-- packages/ui/src/components/ForgeAlert.vue | 2 +- .../ui/src/components/ForgeAutoComplete.vue | 6 ++-- packages/ui/src/components/ForgeChip.vue | 4 ++- .../ui/src/components/ForgeDatepicker.vue | 17 ++++++----- packages/ui/src/components/ForgeForm.vue | 7 +++-- .../ui/src/components/ForgeInlineEditor.vue | 14 +++++----- packages/ui/src/components/ForgeLink.vue | 6 ++-- .../components/ForgeMultiSelectPreview.vue | 9 ++++-- .../ui/src/components/ForgeScratchpad.vue | 8 +++--- .../file-uploader/ForgeFileUploader.vue | 4 +-- .../file-uploader/components/DragDropArea.vue | 2 +- .../file-uploader/components/FileInfo.vue | 28 +++++++++++-------- .../file-uploader/components/UploadButton.vue | 6 ++-- .../file-uploader/components/UploadStatus.vue | 4 +-- .../file-uploader/utilities/utilities.ts | 2 +- .../table/ForgeColumnCustomiser.vue | 7 +++-- .../table/ForgePaginationHeader.vue | 3 +- .../ui/src/components/table/ForgeTable.vue | 21 +++++++------- packages/ui/src/passthroughs/Tree.pt.ts | 2 -- 22 files changed, 101 insertions(+), 71 deletions(-) create mode 100644 packages/ui/eslint.config.mjs diff --git a/packages/ui/eslint.config.mjs b/packages/ui/eslint.config.mjs new file mode 100644 index 000000000..0a37f9636 --- /dev/null +++ b/packages/ui/eslint.config.mjs @@ -0,0 +1,12 @@ +import {config} from "eslint-config-custom/vue" + +export default [ + ...config, + { + "rules": { + "@typescript-eslint/no-explicit-any": "warn", + "vue/require-prop-types": "warn", + "vue/valid-v-for": "warn" + } + } +]; diff --git a/packages/ui/package.json b/packages/ui/package.json index d490c3ac7..19a5047f6 100644 --- a/packages/ui/package.json +++ b/packages/ui/package.json @@ -30,7 +30,9 @@ "test:unit": "vitest --ui --coverage", "build": "vite build", "build:watch": "vite build --watch", - "preview": "vite preview" + "preview": "vite preview", + "lint": "eslint src", + "lint:fix": "eslint src --fix" }, "dependencies": { "@azure/abort-controller": "^2.0.0", diff --git a/packages/ui/src/components/ForgeActionButton.vue b/packages/ui/src/components/ForgeActionButton.vue index f9dbfb5cf..a35e2114e 100644 --- a/packages/ui/src/components/ForgeActionButton.vue +++ b/packages/ui/src/components/ForgeActionButton.vue @@ -11,8 +11,8 @@ import { ref } from "vue"; const loading = ref(false) export interface ForgeActionButtonProps extends /* @vue-ignore */ ButtonProps { - action: Function, - errorAction: Function, + action: (...param: any[]) => Promise, + errorAction: (...param: any[]) => Promise, errorParams?: Array, params?: Array } diff --git a/packages/ui/src/components/ForgeAlert.vue b/packages/ui/src/components/ForgeAlert.vue index 5fbf00e36..048795672 100644 --- a/packages/ui/src/components/ForgeAlert.vue +++ b/packages/ui/src/components/ForgeAlert.vue @@ -2,7 +2,7 @@ diff --git a/packages/ui/src/components/ForgeAutoComplete.vue b/packages/ui/src/components/ForgeAutoComplete.vue index 51f850390..3234af64d 100644 --- a/packages/ui/src/components/ForgeAutoComplete.vue +++ b/packages/ui/src/components/ForgeAutoComplete.vue @@ -1,6 +1,8 @@ diff --git a/packages/ui/src/components/ForgeChip.vue b/packages/ui/src/components/ForgeChip.vue index d1710f28b..d81e42e9a 100644 --- a/packages/ui/src/components/ForgeChip.vue +++ b/packages/ui/src/components/ForgeChip.vue @@ -1,6 +1,8 @@ diff --git a/packages/ui/src/components/ForgeDatepicker.vue b/packages/ui/src/components/ForgeDatepicker.vue index c11139bc7..f0380dd2a 100644 --- a/packages/ui/src/components/ForgeDatepicker.vue +++ b/packages/ui/src/components/ForgeDatepicker.vue @@ -5,15 +5,18 @@
- - + - +
@@ -22,7 +25,7 @@ - {{ errorMessage }} + {{ errorMessage }}