unsure about the theta, phi -> ra, dec conversion

[martamonelli]

I'm a bit confused by lines 380-387 in scanning.py:

beamconv/beamconv/scanning.py

Lines 380 to 387 in e13f52e

	# From (theta,phi) to (ra,dec) convention
	# Also, all angles are converted in degrees
	ra = np.degrees(phi_out) - 180.
	dec = np.degrees(theta_out) - 90.
	psi = np.degrees(psi_out)
	# Calculate the quaternion
	q_bore = Q.radecpa2quat(ra, dec, psi)

Shouldn't the theta, phi -> ra, dec conversion be

ra = np.degrees(phi)
dec = 90. - np.degrees(theta)

Maybe there was a reason why we wrote the conversion this way, but I cannot remember. I'm writing here just in case someone does.