RabbitMq should be stopped even if tests were interrupted

[ov7a]

if a test was interrupted and, subsequently, stop() was not called then rabbit still runs.

RabbitMq should be stopped after tests, even if stop was not called. May be launching it in subprocess would help.

[AlejandroRivera]

i tried a few times and in various ways to interrupt the execution of thecom.sample.project.EmbeddedRabbitMqTest test before the @After block (which calls rabbitMq.stop();) is executed, but I was never able to get RabbitMQ process to stick around.

Can you provide more details about how to reproduce this?

[ov7a]

Ok, I'll try to make MWE tomorrow.

[ov7a]

Leaves RabbitMq running after test execution.
Without System.exit() works fine.

import io.arivera.oss.embedded.rabbitmq.EmbeddedRabbitMq;
import io.arivera.oss.embedded.rabbitmq.EmbeddedRabbitMqConfig;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Test;

public class RabbitTest {

    static EmbeddedRabbitMq rabbitMq;

    @Test
    public void rabbitTest() {
        System.exit(0);
    }

    @BeforeClass
    public static void init() {
        EmbeddedRabbitMqConfig config = new EmbeddedRabbitMqConfig.Builder().rabbitMqServerInitializationTimeoutInMillis(5000).build();
        rabbitMq = new EmbeddedRabbitMq(config);
        rabbitMq.start();
    }

    @AfterClass
    public static void destroy() {
            rabbitMq.stop();
    }
}

[ov7a]

Another, more real test-case. One can restart tests during debugging (started test, stopped at breakpoint, fixed code, restarted). In this case RabbitMq would not be stopped.

[AlejandroRivera]

I've pushed a branch containing a test to try to reproduce the issue and i just don't get the same results you do.

Try checking out the branch test/issue-28, then running the bash script found in the folder src/test/java/issue28. Feel free to modify the test to do System.exit(0) or anything you'd like.

For me, the output of running that script looks like this:

$ ./test.sh 
Any RabbitMQ process found?
No process found.

Executing test that will exit without stopping the Embedded RabbitMQ process...
RabbitMQ processes:
RabbitMQ process found with pid: 53900
  PID TTY           TIME CMD
53900 ttys004    0:01.29 /var/folders/5v/x81_dvcn11ddrkb2ybs56k_r0000gn/T/rabbitmq_server-3.6.5/erts-6.4/bin/../../erts-6.4/bin/beam.smp -W w -A 128 -P 1048576 -t 5000000 -stbt db -K true -B 
Waiting for mvn to finish...
Maven exit status: 1
Is RabbitMQ still running?
No process found.

[ov7a]

I've launched test.sh with zero changes and got this output:

Any RabbitMQ process found?
No process found.

Executing test that will exit without stopping the Embedded RabbitMQ process...
RabbitMQ processes:
RabbitMQ process found with pid: 7371
  PID TTY          TIME CMD
 7371 pts/10   00:00:02 beam.smp
Waiting for mvn to finish...
Maven exit status: 1
Is RabbitMQ still running?
Uh-oh! RabbitMQ is still running! 7371

My system is Ubuntu Mate 16.04 LTS

[AlejandroRivera]

Interesting! My system is Mac OS X 10.11.6

I'll do some more research when i have some spare time.
Thanks for the help so far 👍

[noorul]

My system is Mac OS X 10.12.4 and I can reproduce this even with a successful test. I ensured that stop() is called.

$ ps -ef | grep -i [r]abbit
  501 87336     1   0  8:59PM ??         0:00.00 /var/folders/j6/4qlzsrl541q6nqyfhbkmfnvr0000gn/T/rabbitmq_server-3.6.6/erts-6.4/bin/../../erts-6.4/bin/epmd -daemon

[AlejandroRivera]

did stop() finish successfully?
Can you enable debug for io.arivera.* package and share the logs?