-
Notifications
You must be signed in to change notification settings - Fork 87
Description
Currently, the content library uses a query parameter named currentLibraryRoute for the navigation. All the words in this name are redundant. A name like "element type" or "page" would be more appropriate. We may also consider to use the path instead of query parameters. That is more appropriate if we also want to add a route for each element.
The code is using and mutating the global window.location and window.history variables directly, while we are using React Router in the rest of the code to handle this complexity. It seems to me like the internal QueryParamsRouterImpl class is a temporary placeholder and that it's meant to be provided from the outside of the ContentLibrary component, implementing the current routing tools from each use case. As a part of this issue, we should fix this, either by implementing the routing specifically for each of the two use cases, or solve it internally in the package by adding a dependency to React Router.
Definition of done
- The content library uses appropriate URLs as described above
- All routing in both instances of the library (in
dashboardandapp-development) is managed using React Router
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Status