Project Review

[rahulkore]

1. Package bean sounds wrong for entity objects , Always keep entity objects inside entity package .
2. Use @DaTa annotations from lombok package for dynamic getters and setters , won't have to create getters and setters manually for all the parameters in entity classes.
3. Instead of prepared statements in DAO implementations , you could use JPA (Java persistence API) , it gives more flexibility in terms of querying the db.
   • It provides methods such as findById() where you won't have to write native sql queries explicitly.
   • Internally JPA uses prepared statements only , so it does the job of creating the corresponding queries for you.
4. good job on separating the DB Util class . [nit] => always close the conn object that you open.
5. conn object could have been globalized or passed as a reference .
6. In jpa , no need to create conn objects , it does the job for us . pasting some links for JPA
   • https://www.baeldung.com/the-persistence-layer-with-spring-data-jpa
   • https://www.baeldung.com/learn-jpa-hibernate
7. good job on creating custom exceptions .
8. put Use cases classes in service layer where all the business logic must reside.
9. separate controller , service layer must be present .
10. could remove DBUtil from utility into configuration package and initialize the conn objects using dependency injection. Pasting some useful links for dependency injections below.
    • https://www.baeldung.com/spring-dependency-injection
    • https://medium.com/edureka/what-is-dependency-injection-5006b53af782
11. functionality is in working condition so that's good.
12. Just focus on the aspects that i have mentioned above , you'll be good to go.
13. good job on camel casing and meaningful variable names.
14. Below site has some small projects with different spring boot concepts in it , do go through once on your own pace.
    - https://www.springboottutorial.com/spring-boot-projects-with-code-examples

[Ashish33000]

Sir it was 5th unit simple jdbc project not spring project we didn't know that time to use lomdok

…

On Sun, 19 Feb 2023, 23:15 Rahul Kore, ***@***.***> wrote: 1. Package bean sounds wrong for entity objects , Always keep entity objects inside entity package . 2. Use @DaTa <https://github.com/DaTa> annotations from lombok package for dynamic getters and setters , won't have to create getters and setters manually for all the parameters in entity classes. 3. Instead of prepared statements in DAO implementations , you could use JPA (Java persistence API) , it gives more flexibility in terms of querying the db. - It provides methods such as findById() where you won't have to write native sql queries explicitly. - Internally JPA uses prepared statements only , so it does the job of creating the corresponding queries for you. 4. good job on separating the DB Util class . [nit] => always close the conn object that you open. 5. conn object could have been globalized or passed as a reference . 6. In jpa , no need to create conn objects , it does the job for us . pasting some links for JPA - https://www.baeldung.com/the-persistence-layer-with-spring-data-jpa - https://www.baeldung.com/learn-jpa-hibernate 7. good job on creating custom exceptions . 8. put Use cases classes in service layer where all the business logic must reside. 9. separate controller , service layer must be present . 10. could remove DBUtil from utility into configuration package and initialize the conn objects using dependency injection. Pasting some useful links for dependency injections below. - https://www.baeldung.com/spring-dependency-injection - https://medium.com/edureka/what-is-dependency-injection-5006b53af782 11. functionality is in working condition so that's good. 12. Just focus on the aspects that i have mentioned above , you'll be good to go. 13. good job on camel casing and meaningful variable names. 14. Below site has some small projects with different spring boot concepts in it , do go through once on your own pace. - https://www.springboottutorial.com/spring-boot-projects-with-code-examples — Reply to this email directly, view it on GitHub <#27>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUYX4SMLUZWRF3ZTRFOOJEDWYJL5HANCNFSM6AAAAAAVBCU2HE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>