Feature Request: Add default_prefix option in the platform-landing-zone.tfvars

[fkaksa]

Is there an existing issue for this?

• I have searched the existing issues

Infrastructure as Code Type? (Required)

terraform

Starter Module? (Required)

terraform - microsoft_cloud_for_sovereignty

Use Case (Required)

We created landing zone architecture where we have multiple SLZs deployed under 1 Tenant. To be able to support that, we must configure default prefix for Management Groups.

In the version v8 of the started module of the Azure Landing Zones Accelerator, the default_prefix variable simplified the setup by automatically prepending a prefix to all Management Group IDs.

In the latest version, this has been replaced with the steps described here, where you first must clone the lib repository and configure management groups manually. This approach is too complicated in my option, specially when you would need to update the lib directory with the newest remote changes, because there will be merge conflict.

Proposed Solution (Required)

Add a new variable in your inputs.tfvars file, e.g.:

default_prefix = "my-prefix"

Important Factoids (Optional)

No response

References (Optional)

No response

[jaredfholgate]

Hi. The old SLZ module was manipulating the architecture file, it was not doing anything dynamic. In order to implement this, we would need to update the ptn-alz module and likely the provider too.

CC: @matt-FFFFFF for your thoughts on this.

[matt-FFFFFF]

The way I tend to approach this is to use templating to modify the architecture prior to apply. There is an example of this in the ALZ module examples.

This means we can keep the module simple, customers with advanced requirements have options they can use.

[mc2cloud]

@matt-FFFFFF do you have a link to the example in the ALZ module examples?

Help appreciated

[matt-FFFFFF]

Here is the script that is run:

https://github.com/Azure/terraform-azurerm-avm-ptn-alz/blob/main/examples/default/pre.sh

Here is the templated library:

https://github.com/Azure/terraform-azurerm-avm-ptn-alz/tree/main/examples/default/lib

This can be adapted for multi-environment scenarios where you use variable groups/environments to provide different values.

[mc2cloud]

Perfect! Thank you.

[jaredfholgate]

Also, I am not suggesting this is a good solution, but we do this on our e2e tests to avoid name conflicts: https://github.com/Azure/alz-terraform-accelerator/blob/47ea0fedaed0ee2c920b149eb5408a18794c65af/.github/workflows/end-to-end-test.yml#L178

[fkaksa]

@mc2cloud @jaredfholgate thank you guys for your support!

@mc2cloud can you maybe give me approximately estimation when you think that this feature can be implemented?

[jaredfholgate]

CC: @matt-FFFFFF in case you want to provide any further updates.