Bug: LAW Id error after upgrading to version 12 with firewall insights set active

[moler-udi]

Is there an existing issue for this?

• I have searched the existing issues

Infrastructure as Code Type? (Required)

terraform

Starter Module? (Required)

terraform - platform_landing_zone

Expected Behaviour (Required)

Adding insight and law id, no error should be thrown in plan after upgrading to latest (12) version:

firewall_policy = {
  name = "$${primary_firewall_policy_name}"
  insights = {
	enabled                            = true
	default_log_analytics_workspace_id = "$${log_analytics_workspace_id}"
	retention_in_days                  = 5
  }
}

Actual Behaviour (Required)

Plan throws error msg when trying to run with insight block with law id in it.
Expect no error activating firewall policy insight with reference to default law id tfvar.

It complains of lowercase G in id set in hub-and-spoke-vnet.tfvars example files, please update examples with changes below:

management_resource_group_id  = "/subscriptions/$${subscription_id_management}/resourceGroups/$${management_resource_group_name}"

log_analytics_workspace_id = "$${management_resource_group_id}/providers/Microsoft.OperationalInsights/workspaces/$${log_analytics_workspace_name}"

[jaredfholgate]

Thanks for reporting. I know that the resource group ID was lowercase here to get round another problem, however I am unsure whether that still exists. We'll need to test a full deployment with the casing changed.

If we still need the casing to be different for some reason, then it may make sense to fix it somewhere else, e.g. here: https://github.com/Azure/terraform-azurerm-avm-res-network-firewallpolicy/blob/06f8dc13d42c323df0ff4777262c4da9fb819fce/main.tf#L54

[moler-udi]

Yeah tried to look where the firewall policy setting would need the change, but my understanding this was just a az_api thing, and where the workspace id is used seems to be using azurerm-provider. So confused as to why I got the error when trying to activate insights.

Agreed best would be to squash the need at the source