Skip to content

Fixed a crash caused by excessively long stack traces. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LionelDrew wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed a crash caused by excessively long stack traces. #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c857574
Fixed a crash when messages were too long.
LionelDrew Jan 7, 2026
493d01a
Merge branch 'master' into crash_long_msg
LionelDrew Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utility.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,11 +892,16 @@ VOID Print (LPWSTR messagew)
const size_t MAXMESSAGELENGTH = 5119;
size_t count = 0;
CHAR messagea [MAXMESSAGELENGTH + 1];
if (wcstombs_s(&count, messagea, MAXMESSAGELENGTH + 1, messagew, _TRUNCATE) != 0) {
if (wcstombs_s(&count, messagea, MAXMESSAGELENGTH + 1, messagew, MAXMESSAGELENGTH) != 0) {
// Failed to convert the Unicode message to ASCII.
assert(FALSE);
return;
}
if (count >= MAXMESSAGELENGTH)
{
Report(L"!!! Print Warning, the message was too long and has been truncated.\n");
}

messagea[MAXMESSAGELENGTH] = '\0';

if (s_reportFile != NULL) {
Expand Down