Use of deprecated constant MT_RAND_PHP in tests

[ryanhblack]

Related to Issue #23. According to the PHP documentation for mt_srand(), the MT_RAND_PHP mode uses an incorrect Mersenne Twister implementation, and it is now deprecated as of PHP 8.3.0.

The correct Mersenne Twister implementation caused the tests using it to fail, so past developers chose to use the old implementation to resolve issue #23. A better fix would be to have the tests expect the correct implementation so the deprecated constant can be removed.

The issue is mitigated by the fact that the deprecated constant is only used in tests (BaconQrCodeTest\Common\BitArrayTest and BaconQrCodeTest\Common\ReedSolomonCodecTest).

[DASPRiD]

Would you like to supply a PR?

[ryanhblack]

I can, but it won't be high priority for me, so it might take some time to update the tests.

[stof]

I find it weird to have a test relying on randomly generated values that work only for a specific seed. The tests should probably be rewritten to perform deterministic logic (which they apparently already do given that changing the algorithm makes the test fail, but the code does not make it clear)

[vlakoff]

I submitted a fix for this issue: #208.

About:

I find it weird to have a test relying on randomly generated values that work only for a specific seed. The tests should probably be rewritten to perform deterministic logic (which they apparently already do given that changing the algorithm makes the test fail, but the code does not make it clear)

It actually seems to be deterministic: the tests pass when using different seeds, and even when removing the mt_srand() calls. The results of mt_rand() are used only to dynamically generate input data—they are not compared against hardcoded values anywhere—so the tests should work regardless of the values it produces. That said, I haven’t examined this in detail.