From 84cc0d5dab66b94082a0fc68eadf0ec23c810b7a Mon Sep 17 00:00:00 2001 From: JercSi Date: Sat, 19 Feb 2022 19:00:08 +0100 Subject: [PATCH 1/2] Non-locale aware of scale and translate --- src/Renderer/Image/SvgImageBackEnd.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Renderer/Image/SvgImageBackEnd.php b/src/Renderer/Image/SvgImageBackEnd.php index 714da6e..a6a1ce7 100644 --- a/src/Renderer/Image/SvgImageBackEnd.php +++ b/src/Renderer/Image/SvgImageBackEnd.php @@ -97,7 +97,7 @@ public function scale(float $size) : void $this->xmlWriter->startElement('g'); $this->xmlWriter->writeAttribute( 'transform', - sprintf('scale(%s)', round($size, self::PRECISION)) + sprintf('scale(%.' . self::PRECISION . 'F)', round($size, self::PRECISION)) ); ++$this->stack[$this->currentStack]; } @@ -111,7 +111,7 @@ public function translate(float $x, float $y) : void $this->xmlWriter->startElement('g'); $this->xmlWriter->writeAttribute( 'transform', - sprintf('translate(%s,%s)', round($x, self::PRECISION), round($y, self::PRECISION)) + sprintf('translate(%.' . self::PRECISION . 'F,%.' . self::PRECISION . 'F)', round($x, self::PRECISION), round($y, self::PRECISION)) ); ++$this->stack[$this->currentStack]; } From 382d5fcd99c25e20f8acd3a651f60645dcaf33d6 Mon Sep 17 00:00:00 2001 From: JercSi Date: Fri, 22 Apr 2022 14:39:18 +0200 Subject: [PATCH 2/2] Fix lint warning - too long line --- src/Renderer/Image/SvgImageBackEnd.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Renderer/Image/SvgImageBackEnd.php b/src/Renderer/Image/SvgImageBackEnd.php index a6a1ce7..7459df2 100644 --- a/src/Renderer/Image/SvgImageBackEnd.php +++ b/src/Renderer/Image/SvgImageBackEnd.php @@ -19,6 +19,8 @@ final class SvgImageBackEnd implements ImageBackEndInterface { private const PRECISION = 3; + private const SCALE_FORMAT = 'scale(%.' . self::PRECISION . 'F)'; + private const TRANSLATE_FORMAT = 'translate(%.' . self::PRECISION . 'F,%.' . self::PRECISION . 'F)'; /** * @var XMLWriter|null @@ -97,7 +99,7 @@ public function scale(float $size) : void $this->xmlWriter->startElement('g'); $this->xmlWriter->writeAttribute( 'transform', - sprintf('scale(%.' . self::PRECISION . 'F)', round($size, self::PRECISION)) + sprintf(self::SCALE_FORMAT, round($size, self::PRECISION)) ); ++$this->stack[$this->currentStack]; } @@ -111,7 +113,7 @@ public function translate(float $x, float $y) : void $this->xmlWriter->startElement('g'); $this->xmlWriter->writeAttribute( 'transform', - sprintf('translate(%.' . self::PRECISION . 'F,%.' . self::PRECISION . 'F)', round($x, self::PRECISION), round($y, self::PRECISION)) + sprintf(self::TRANSLATE_FORMAT, round($x, self::PRECISION), round($y, self::PRECISION)) ); ++$this->stack[$this->currentStack]; }