-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Hi @oj713
I have transferred your correction work to the ecomon package - at least I think I have! See the README. The first bit is me decoding Caroline's original which is tricky because we don't have her original data file in hand. The second part is the use case when folded into the ecomon package.
There is at least one discrepancy between Caroline's original and your implementation. You can see where I trip up here Essentially your multiplier is 1 while hers is 10. I'm not sure what to think - the old story about a person with two watches doesn't know what time it is. Do you have any thoughts on this?
Also, I think the 95% threshold has to be divided by 100 to make it comparable to the percZ_stn variable which is 0-1. Otherwise everything is below the threshold! That is here.
I have added you and Caroline as authors, and bumped the version. I think it will be good to get this nailed down and behind us. After you get a chance to poke around (no hurry at this end), I would like to run it by Caroline.
Thanks! Ben