Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Remove pointless macros from crout.hpp #1500

@1uc

Description

@1uc

The naming conventions in solveCrout need fixing. y isn't a good name for a pivot vector, p is more canonical, but p is something completely different, unless it's used through the macro y_[i] (which is p[y[i]]).

The the blocks of code are completely duplicated and can be trivially be deduplicated using a sensible abstraction for y_.

The second copy of the comments is incorrect/misleading about y.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions