Skip to content

Commit fbcf856

Browse files
committed
merge jobs into build-docker and try to use artifact name with image name in it to work around (409) Conflict: an artifact with this name already exists
1 parent 54e1725 commit fbcf856

File tree

4 files changed

+21
-58
lines changed

4 files changed

+21
-58
lines changed

.github/workflows/build-docker-image.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ jobs:
7979
- name: Upload digest
8080
uses: actions/upload-artifact@v4
8181
with:
82-
name: digests-${{ env.PLATFORM_PAIR }}
82+
name: digests-${{ inputs.image }}-${{ env.PLATFORM_PAIR }}
8383
path: ${{ runner.temp }}/digests/*
8484
if-no-files-found: error
8585
retention-days: 1
@@ -97,7 +97,7 @@ jobs:
9797
uses: actions/download-artifact@v4
9898
with:
9999
path: ${{ runner.temp }}/digests
100-
pattern: digests-*
100+
pattern: digests-${{ inputs.image }}-*
101101
merge-multiple: true
102102

103103
- name: Login to GHCR

.github/workflows/build-docker-minimal.yml

Lines changed: 0 additions & 24 deletions
This file was deleted.

.github/workflows/build-docker-vcpkg-installed.yml

Lines changed: 0 additions & 15 deletions
This file was deleted.

.github/workflows/build-docker.yml

Lines changed: 19 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,26 @@
11
name: build-docker
22

33
on:
4-
workflow_run:
5-
workflows: [build-docker-vcpkg-installed]
6-
types:
7-
- completed
4+
push:
5+
branches: [ "main", "dev", "unstable" ]
6+
tags: [ "*" ]
7+
workflow_dispatch:
88

99
jobs:
10-
on-success:
11-
runs-on: ubuntu-latest
12-
if: ${{ github.event.workflow_run.conclusion == 'success' }}
13-
steps:
14-
- run: echo 'The triggering workflow passed'
10+
# specifically package this so build process doesn't keep redoing it
11+
build-docker-vcpkg-installed:
12+
uses: ./.github/workflows/build-docker-image.yml
13+
with:
14+
image: vcpkg-installed
1515

16-
- uses: ./.github/workflows/build-docker-image.yml
17-
with:
18-
image: firestarr
16+
build-docker-normal:
17+
needs: [build-docker-vcpkg-installed]
18+
uses: ./.github/workflows/build-docker-image.yml
19+
with:
20+
image: firestarr
1921

20-
on-failure:
21-
runs-on: ubuntu-latest
22-
if: ${{ github.event.workflow_run.conclusion == 'failure' }}
23-
steps:
24-
- run: echo 'The triggering workflow failed'
22+
build-docker-minimal:
23+
needs: [build-docker-normal]
24+
uses: ./.github/workflows/build-docker-image.yml
25+
with:
26+
image: firestarr-minimal

0 commit comments

Comments
 (0)