Version 3586 offsets causing CLR exceptions - firstPersonVehicleCam crashes on load

[shalinratna]

Hey, getting consistent crashes about 10 seconds after game load with the latest build. Pretty sure the new 3586
offsets are pointing to wrong addresses.

Environment:

• Game Version: 1.0.3586.0
• Mod Version: Latest (commit adfcb55)
• ScriptHookV + ScriptHookVDotNet installed

The mod loads fine initially but crashes with CLR exception 0xE0434352. Exception.log shows it's hitting clr.dll
and System.ni.dll in the stack trace, which makes sense since the corrupted camera metadata is probably getting
accessed by .NET scripts. ExtendedCameraSettings.log shows repeated "Couldn't find camera hash for entity. Base type was
firstPersonVehicleCam" errors right before crash, so it's definitely related to the recent offset changes for
first-person vehicle cam.

Look at changing these offsets I can't see the full logs.
minPitch: 936
minPitchExt: 904
maxPitchExt: 908

These were changed from the old values (+48 bytes) but I'm guessing they weren't verified with a debugger? Seems
like they might be off by a few bytes or pointing to a completely different struct member.

Suggestion:
Either add version detection to disable the mod on 3586+ until offsets are confirmed, or add better bounds
checking before dereferencing those pointers. Right now getCamMetadataForHash dereferences *it before any
validation, so if the pool iterator is corrupted it's an instant crash.

[CamxxCore]

Hello.

Please provide the information I requested from the exception.log or I cannot assist. I am unable to reproduce the issue as you are experiencing it.

The offsets were updated based on static analysis of the latest Social Club version (1.0.3586.0) and the mod was thoroughly tested for stability within my environment.

To your other point, I don't intend to make any further changes to the codebase at this time; this mod is nw over 10 years old... I wrote the code when I was a very amateur programmer so I'm very aware that it's a mess and full of bad practices.

You are more than welcome to fix some of those things and revive the mod in a more substantial way!

[shalinratna]

Hey, thanks for responding. Here's the exception.log output from the crash:

[21:14:30] SVL_COM_CALLABLE_RT_EXCEPTION (0xE0434352) @ Address 0x7FF9B2C1804A (KERNELBASE.dll+0xC804A base:0x7FF9B2B50000)
Platform: gtav-legacy Our Base: 00007FF9073F0000
RIP: 7FF9B2C1804A RSP: BFC79F9D90 RBP: 5 RAX: 11000
RBX: BFC79F9F48 RCX: 0 RDX: 0 RDI: E0434352 RSI: 1
R8: 274D4A10001 R9: 274D4A10400 R10: 7FF9B5889D9E R11: 0
R12: 4000 R13: 7FF9B2EF0198 R14: BFC79F9F48 R15: BFC79FE180
first 10 bytes: 0F 1F 44 00 00 48 8B 8C 24 C0

Trace 0 0000000180012d26 (ntdll.dll+12D26)
Trace 1 00000001800120f6 (ntdll.dll+120F6)
Trace 2 000000018000a961 (ntdll.dll+A961)
Trace 3 00000001800c804a (KERNELBASE.dll+C804A)
Trace 4 0000000180181078 (clr.dll+181078)
Trace 5 0000000180180d53 (clr.dll+180D53)
Trace 6 00000001802cd5c4 (System.ni.dll+2CD5C4)
Trace 7 00000001802ccc86 (System.ni.dll+2CCC86)
Trace 8 00000001802cbe00 (System.ni.dll+2CBE00)
Trace 9 00007ffabca57fde (GTA5.exe+7FF93CA57FDE)

Setup:

• Game Version: 1.0.3586.0 (Social Club, latest)
• Mod Version: Latest from your repo (commit adfcb55)
• ScriptHookV + ScriptHookVDotNet3 installed
• Other .NET scripts running: ForcedFirstPersonAim.dll, RadarZoom.dll, Fast_Draw.dll

What happens:
Game loads fine, mod runs for about 10 seconds, then crashes with CLR exception 0xE0434352. The stack trace shows it's hitting .NET runtime (clr.dll/System.ni.dll) even though your mod is native C++, maybe a conflict with ScriptHookVDotNet mods.

Appreciate the work you've put into this over the years. If you don't have time to fix it I understand and just wanted to provide the
logs in case it helps. I am a programmer myself and looking to get into creating mods or add to my game development. Thanks!

[CamxxCore]

What I can suggest is that you go through the process of elimination with your .NET mods - As its very likely this is a conflict from something else you are using. The changes I made today were trivial and almost certainly wouldn't be the direct cause of what you are experiencing (unless there is a mod conflict). The issue just may not have been triggered when the offsets were outdated. I can confirm with 100% certainty the 3 offsets I changed are now the correct ones - redundantly verified by checking the functionality in gameplay.

[CamxxCore]

The issue seems to stem from an issue with the implementation of .NET script hook. I spent a fair amount of time over the weekend (within the limited time I have) trying to understand the crash or find a potential workaround to no avail. The mod will have to be considered incompatible with ScriptHookVDotNet on later game versions for now.

scripthookvdotnet/scripthookvdotnet#976

[Chiheb-Bacha]

@CamxxCore Hey. Apparently SHVDN doesn't do well with exception handlers, and it seems one of your most recent additions is indeed related to exception handling, so I'd assume that's the cause.

On an unrelated note, I have been porting many projects to Enhanced as of lately, and I've received requests to port Extended Camera Settings as well. What are your plans with it? are you already working on a port? If so, I could help with that. I already have your Pause Menu Helper ported (although not made public, and not really tested), so i could send that over. Same applies to DismembermentASI (I have every pattern covered, except for the DrawSkeleton function, which i couldn't find yet).