Open SaR node button action does not work as expected

[rosstitmarsh]

I have a button using the "Open SaR node" action with a valid composite snapshot node id specified. The node is nested inside two folders in SaR.

• When I click the button it opens Save and Restore with no node opened.

  Exception in thread "JavaFX Application Thread" java.lang.NullPointerException: Cannot invoke "javafx.scene.control.TreeItem.getValue()" because "node" is null
          at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.recursiveSearch(SaveAndRestoreController.java:816)
          at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.locateNode(SaveAndRestoreController.java:832)
          at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.lambda$openNode$48(SaveAndRestoreController.java:1354)
          at com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:456)
          at java.base/java.security.AccessController.doPrivileged(Unknown Source)
          at com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:455)
          at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
          ...
  

• Click the button a second time and it uncollapses the first level folder in the sidebar

  Exception in thread "JavaFX Application Thread" java.lang.IndexOutOfBoundsException: 0 >= 0
          at javafx.scene.control.MultipleSelectionModelBase$SelectedIndicesList.get(MultipleSelectionModelBase.java:684)
          at javafx.scene.control.MultipleSelectionModelBase$SelectedIndicesList.get(MultipleSelectionModelBase.java:638)
          at com.sun.javafx.scene.control.SelectedItemsReadOnlyObservableList.get(SelectedItemsReadOnlyObservableList.java:99)
          at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.nodeDoubleClicked(SaveAndRestoreController.java:591)
          at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.lambda$openNode$48(SaveAndRestoreController.java:1355)
          at com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:456)
          ...
  

• Click the button a third time and it uncollapses the second level folder that contains the node but does not open it

  Exception in thread "JavaFX Application Thread" java.lang.IndexOutOfBoundsException: 0 >= 0
          at javafx.scene.control.MultipleSelectionModelBase$SelectedIndicesList.get(MultipleSelectionModelBase.java:684)
          at javafx.scene.control.MultipleSelectionModelBase$SelectedIndicesList.get(MultipleSelectionModelBase.java:638)
          at com.sun.javafx.scene.control.SelectedItemsReadOnlyObservableList.get(SelectedItemsReadOnlyObservableList.java:99)
          at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.nodeDoubleClicked(SaveAndRestoreController.java:591)
          at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.lambda$openNode$48(SaveAndRestoreController.java:1355)
          at com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:456)
          ...
  

• Clicking the button further times does not do anything, repeating the error above.

Trying it with a regular snapshot behaves differently, it does open the snapshot but after two clicks. The first opens SaR, the second uncollapses the first level folder and opens the snapshot.

[georgweiss]

@rosstitmarsh, thanks for reporting this. However, I need to ask for more information as I cannot reproduce this. Please attach your bob file with the action button, and please also attach a screen shot from the Save&Restore UI showing the node specified for the action button.

What version of Phoebus are you running? Do you build from master or from Maven artifacts?

[rosstitmarsh]

Bob file used:

<?xml version="1.0" encoding="UTF-8"?>
<display version="2.0.0">
  <name>Display</name>
  <widget type="action_button" version="3.0.0">
    <name>Action Button</name>
    <actions>
      <action type="open_sar_node">
        <description>Open SaR node</description>
        <node_id>c791b71d-504b-4a49-8b8a-13c60d2287ce</node_id>
      </action>
    </actions>
    <x>20</x>
    <y>20</y>
    <tooltip>$(actions)</tooltip>
  </widget>
</display>

I have asked my controls team to add the further Phoebus details.

[GDH-ISIS]

I have updated our use case here as our backend services and front end client differed by 6 months - @rosstitmarsh, would you be good enough to update this issue with your findings.

Backend phoebus services (including S&R) built to master commit db2ce5f (jdk 22)
Front end Phoebus client (for Windows) also built to master commit db2ce5f (jdk 25)

[rosstitmarsh]

Using the new versions as mentioned now gives the following.

• First click of the action button opens SaR and uncollapses the first folder level and gives this error

  Exception in thread "JavaFX Application Thread" java.lang.NullPointerException: Cannot invoke "javafx.scene.control.TreeItem.getValue()" because "node" is null
  	at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.recursiveSearch(SaveAndRestoreController.java:847)
  	at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.locateNode(SaveAndRestoreController.java:863)
  	at org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController.lambda$openNode$2(SaveAndRestoreController.java:1374)
  	at com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:456)
  	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
  	at com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:455)
  	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
  	at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
  	at com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(WinApplication.java:185)
  	at java.base/java.lang.Thread.run(Unknown Source)
  

• Second click does open the composite snapshot and uncollapses the next folder and produces no errors

• Subsequent clicks keep uncollapsing folder levels until the one containing the node is reached, producing no errors

[georgweiss]

Yes, running same "version" of client and service is a good idea.

In any case, I've reproduced this and will come up with a fix.