Merge pull request #1357 from myk002/myk_dry_buckets

[fix/dry-buckets] don't empty buckets for in-use wells

Author: myk002

changelog.txt

@@ -34,6 +34,7 @@ Template for new versions:
 - `gui/settings-manager`: standing orders save/load now includes the reserved barrels setting
 
 ## Fixes
+- `fix/dry-buckets`: don't empty buckets for wells that are actively in use
 
 ## Misc Improvements
 - `immortal-cravings`: goblins and other naturally non-eating/non-drinking races will now also satisfy their needs for eating and drinking

fix/dry-buckets.lua

@@ -11,6 +11,11 @@ local emptied = 0
 local in_building = 0
 for _,item in ipairs(df.global.world.items.other.BUCKET) do
     if item.flags.in_job then goto continue end
+    local well = dfhack.items.getHolderBuilding(item)
+    if well and well:getType() == df.building_type.Well and well.well_tag.whole ~= 0 then
+        -- bucket is in a well and the well is actively being used
+        goto continue
+    end
     local emptied_bucket = false
     local freed_in_building = false
     for _,contained_item in ipairs(dfhack.items.getContainedItems(item)) do