Skip to content

Review ssantosb #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssantosb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Review ssantosb #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ <h1>My personal web page</h1>
<div class="container">
<div class="row">
<div class="col-12">
<!-- Recomendación: Eliminar las unidades de los width y height. Estos no son adecuados según el validador-->
<img class="rounded mx-auto d-block" src="images/bateroman.jpg" alt="Me playing drums" title="A personal picture" width="370px" height="500px"/>

</div>
Expand All @@ -46,6 +47,7 @@ <h1>My personal web page</h1>
<div class = "container-fluid" id="greetings">
<div class="row">
<div class="col-12 col-sm-12 col-md-12 col-lg-12">
<!--Recomendación: Modificar las etiquetas de cierre de esta sección. Creo que se te olvidó corregirlos y quedaron todos iguales a h4 en el cierre-->
<h2 class="special">Greetings my friend.</h4>
<p>
This is a small fragent gifted to my by the cyberspace to talk a little about myself and introducte me to the world. Specially because the quarintine makes it harder or impossible to make contact with
Expand Down Expand Up @@ -103,6 +105,7 @@ <h3>Music</h3>
</thead>
<tbody>
<tr>
<!--Recomendación: No utilizar elementos th adentro de un tbody. -->
<th scope="row">Name</th>
<td>Daniel</td>
</tr>
Expand Down Expand Up @@ -165,6 +168,7 @@ <h3>Some of my favorite videos</h3>
I like this video because of the music but also due too the drawing and animation it has. The video was made by the artist Felix Colgrave for the song <em>Source</em> by the band Fever the Ghost.
</p>
<div class ="embed-responsive embed-responsive-16by9">
<!--Recomendación: No utilizar frameborder, pues es un atributo obsoleto. Algo que podrias usar es bootstrap para realizar estas configuraciones. Si no estoy mal, existen clases de bootstrap que te configuran estas cosas facilmente-->
<iframe class="embed-responsive-item" width="560" height="315" src="https://www.youtube.com/embed/9RHFFeQ2tu4" frameborder="0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
</div>

Expand Down Expand Up @@ -304,6 +308,7 @@ <h3>PetFun</h3>
</div>
</div>
<div class="form-group">
<!--Recomendación: Corregir este typo-->
<label for="mail">Your email:</laber>
<input type="text" class="form-control" id="email" name="email" placeholder="example@mail.com">
</div>
Expand All @@ -321,6 +326,7 @@ <h3>PetFun</h3>

</main>
<footer class="footer">
<!--Recomendacion: Utilizar CSS para marcar en negrilla-->
<p><bold>Contact info </bold></p>
<p>Personal mail: d.galindo@uniandes.edu.co</p>
<p><a href="https://www.facebook.com/daniel.galindoruiz">My Facebook</a></p>
Expand Down
Binary file added validaciones.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.