Skip to content

Cleanup makefile#1042

Draft
edznux-dd wants to merge 1 commit intomainfrom
edouard/cleanup-makefiles
Draft

Cleanup makefile#1042
edznux-dd wants to merge 1 commit intomainfrom
edouard/cleanup-makefiles

Conversation

@edznux-dd
Copy link
Contributor

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

The makefile grew organically over time and could be improved (both for maintainability and CI issues with auto expansion for example)

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

@datadog-official
Copy link

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 39.29% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e180313 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments