error with variable length hierarchical data

[macartan]

this warning seems to appear when the second level N is determined by the first level and there is a potential oucoems cll

> fabricate(
+     A = add_level(N = 2, m = 1:2),
+     B = add_level(N = m,
+                   potential_outcomes(Y ~ Z))
+   )
  A m B Y_Z_0 Y_Z_1
1 1 1 1     0     1
2 2 2 2     0     1
3 2 2 3     0     1
Warning messages:
1: In if (nrow(variable_data) == inner_N) { :
  the condition has length > 1 and only the first element will be used
2: In rep(seq_len(nrow(variable_data)), each = N/inner_N) :
  first element used of 'each' argument

[nfultz]

I don't believe this is unique to potential outcomes.

The condition is probably supposed to be:

nrow(variable_data) == length(inner_N)

[graemeblair]

Agree this is a problem. We looked into this. There seem to be a bunch of different cases depending on what you provide to N, how long the data are (either a scalar or a numeric vector).

[tomoya-sasaki]

DelcareDesign team,

Thank you so much for producing these great packages. I have a request related to this issue. It seems that, with the most recent version of R (4.2.1), the function fabricate returns an error instead of a warning when I include multiple levels. It works with R version 4.1.3.

I am wondering if there is a plan to fix this soon. Thank you so much!

The following is the summary output and sessionInfo:

> library(fabricatr)
> fabricate(A = add_level(N = 2, m = 1:2), B = add_level(N = m,potential_outcomes(Y ~ Z)))
Error in if (nrow(variable_data) == inner_N) { : 
  the condition has length > 1

> sessionInfo()
R version 4.2.1 (2022-06-23)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.6 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.7.1
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.7.1

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8    
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8   
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] fabricatr_1.0.0

loaded via a namespace (and not attached):
[1] compiler_4.2.1 cli_3.3.0      rlang_1.0.4   

[nfultz]

See also HenrikBengtsson/Wishlist-for-R#38

[graemeblair]

Another example:

fabricate(
  l1 = add_level(N = 10, n_l2 = 1:10),
  l2 = add_level(N = n_l2, potential_outcomes(Y ~ 0.1 * Z))
)()

[graemeblair]

This is related to potential_outcomes interacting with that N