Skip to content

[BUG] Mixing Web3.js and Ethers.js syntax #68

@DeveloperAmrit

Description

@DeveloperAmrit

Description:
The promiseTx helper uses .sendTransaction(tx), which is Ethers.js syntax, whereas the rest of the SDK expects a Web3.js contract object.

How to Reproduce:
Call promiseTx with a standard Web3 provider.

Actual Behaviour: Method sendTransaction is undefined on Web3 providers.

Expected Behaviour:
Consistently use one library (preferably Web3.js as used in artifacts/index).

Location: StablePay/djed-sdk/src/djed/tradeUtils.js line 130

[y] i want to work on this issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions