Always store in capture buffer, dropping oldest

macaba · macaba · commit dec35d869066 · 2025-11-06T23:13:51.000Z
diff --git a/source/TS.NET/Memory/CaptureCircularBuffer.cs b/source/TS.NET/Memory/CaptureCircularBuffer.cs
@@ -131,11 +131,14 @@ public bool TryStartWrite()
             }
             internalIntervalCaptureTotal++;
 
-            if (currentCaptureCount == maxCaptureCount)
+            lock(readLock)
             {
-                captureDrops++;
-                intervalCaptureDrops++;
-                return false;
+                if (currentCaptureCount == maxCaptureCount)
+                {
+                    captureDrops++;
+                    intervalCaptureDrops++;
+                    FinishRead();       // Remove oldest buffer
+                }
             }
             writeInProgress = true;
             return true;

Original file line number	Diff line number	Diff line change
`@@ -131,11 +131,14 @@ public bool TryStartWrite()`
`131`	`131`	`}`
`132`	`132`	`internalIntervalCaptureTotal++;`
`133`	`133`
`134`		`- if (currentCaptureCount == maxCaptureCount)`
	`134`	`+ lock(readLock)`
`135`	`135`	`{`
`136`		`- captureDrops++;`
`137`		`- intervalCaptureDrops++;`
`138`		`- return false;`
	`136`	`+ if (currentCaptureCount == maxCaptureCount)`
	`137`	`+ {`
	`138`	`+ captureDrops++;`
	`139`	`+ intervalCaptureDrops++;`
	`140`	`+ FinishRead(); // Remove oldest buffer`
	`141`	`+ }`
`139`	`142`	`}`
`140`	`143`	`writeInProgress = true;`
`141`	`144`	`return true;`