Not working on clojurescript 1.10.439

[galdolber]

One error I get is this:

But even when I fixed that, the parser function is failing.

[mtruyens]

I wanted to submit the same error. So far, the parsing does continue to work, despite the compile warning.

[Engelberg]

@galdolber Can you describe the way it is failing? It appears that Clojurescript made a change to the public visibility of some functions, and added a new set of compiler warnings, but the warning should not break the function. I would expect it to still work, as @mtruyens described.

[galdolber]

(instaparse.core/parser "S = AB* AB = A B A = 'a'+ B = 'b'+")

I get:

Rolling back to clojurescript 1.10.339 works fine.

[galdolber]

This is the commit that breaks the code:
clojure/clojurescript@9a8196e

[galdolber]

I was able to fix the issues here: #190

[Engelberg]

I fixed the warning that clojurescript was giving about the use of the private var read-string* from tools.reader. But I am unable to duplicate the bug you are seeing. The test suite is passing under the latest version of clojurescript, and I entered in your sample bug by hand into a clojurescript REPL and it worked fine.

I bumped up the version of tools.reader listed in the dependencies, so perhaps that helped. Please check again against instaparse 1.4.10 and let me know whether you still see a problem. Thanks for your assistance.

[jeroenvandijk]

I can confirm that upgrading from 1.4.9 to 1.4.10 got rid of the warning:

WARNING: var: cljs.tools.reader/read-string* is not public

Which blocked figwheel to compile my code.

Thanks! Btw the README still says 1.4.9 (hence my trial)

[Engelberg]

Just updated README. Thanks for catching that.