[HOLD for payment 2023-08-02] [$1000] Whole App UI cuts off with company popup

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings -> Workspaces
2. Navigate to any Workspace
3. Click Bank Account
4. On Bank setup step 2 -> Click on Company Type
5. Once dropdown is open -> Send app to Background
6. Open app again (It will close popup and refresh which leads to cut off whole app's UI)

Expected Result:

This process should only close popup and load the screen properly

Actual Result:

Whole App's UI cuts off

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.42-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1689572676.mp4

VLVV7406.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689575559714959

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bfc1471539715421
• Upwork Job ID: 1681301579072643072
• Last Price Increase: 2023-07-18

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The page on the bank account is cut off after putting the app into the background while having a picker open and then reopening the app. (only on iOS)

What is the root cause of that problem?

When a Picker is showing, some amount of padding will be applied to the page. This behavior comes from PickerAvoidingView.

App/src/components/ScreenWrapper/index.js

Lines 124 to 127 in 88b9416

	<PickerAvoidingView
	style={styles.flex1}
	enabled={this.props.shouldEnablePickerAvoiding}
	>

PickerAvoidingView is added to our fork to solve this issue.

Here is how the logic works.

When the context.isModalShown is true, we will add the required padding-bottom.
https://github.com/Expensify/react-native-picker-select/blob/master/src/PickerAvoidingView/index.ios.js#L32-L39

isModalShown will be true when the modal that shows the picker shows.
https://github.com/Expensify/react-native-picker-select/blob/107b3786ae6bc155dec05c7fc5ee525d3421dc21/src/index.js#L496-L502

and will be false when the Picker is toggled to hide. This toggling only happens when we press the Done button and the overlay.
https://github.com/Expensify/react-native-picker-select/blob/107b3786ae6bc155dec05c7fc5ee525d3421dc21/src/index.js#L269-L276

It doesn't set the value to false on onDismiss prop because as explained in the comment above, onDismiss will be called after the modal is hidden, but we want to immediately change the value to false as soon as the Picker starts to close/hide.

The problem is, we don't set the isModalShown back to false when the Picker unmounts. In our case, the bank account step (that contains the Picker) is unmounted and replaced with the loading page, then back to the same step again. This makes the isModalShown stuck at true, thus the padding-bottom is there "cutting off" the page.

What changes do you think we should make in order to solve the problem?

Set the isModalShown back to false on component unmount.

componentWillUnmount() {
    if (this.context) {
        this.context.setIsModalShown(false);
    }
}

[conorpendergrast]

Nice and reproducible, thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bfc1471539715421

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@bernhardoj Thanks for the proposal. Your RCA is correct. The solution makes sense but before moving forward with that, can we assess whether onRequestClose would be useful / called in such cases?