-
Notifications
You must be signed in to change notification settings - Fork 47
Description
Describe the bug
The current geometry generation does not fully support T-shaped fabrics.
To Reproduce
Steps to reproduce the behavior:
Use https://github.com/IAmMarcelJung/ICESOC_FABulous_user_project/tree/fix/correct_fabric_csv as a FABulous project and generate the geometry.
Expected behavior
The geometry should be correctly generated.
Other hints
The issue lies somehow in the handling of the termination tiles that are not in the first or last row of the fabric, but in the side of the fabric, as it is the case with the N_term_RAM_IO in the provided example. Instead of Border.NORTHSOUTH, Border.EASTWEST gets assigned to the tileGeom.border in fabric_geometry.py. Also the handling in https://github.com/FPGA-Research/FABulous/blob/main/fabulous/geometry_generator/fabric_geometry.py#L84-L90 does not cover the T-shape case.