switch-interface (virtual/physics)

[magarjoba]

hi
I need to check interfaces.
The most reliable option, as practice has shown, is whether they are part of the virtual switch interface or the physical switch.
I checked the API manually, downloaded the results, selected the values ​​for the function. But I can't get the function to work.

option: 1
https://{ip_fgt}/api/v2/cmdb/system/virtual-switch
#Suitable for revision (6.0.5 - v7.2.5) i tested

{
  "http_method":"GET",
  "size":1,
  "matched_count":1,
  "next_idx":0,
  "revision":"8cc3a06d650301e96ab3572c6e938020",
  "results":[
    {
      "name":"lan",
      "q_origin_key":"lan",
      "physical-switch":"sw0",
      "port":[
        {
          "name":"a",
          "q_origin_key":"a",
          "alias":""
        },
        {
          "name":"lan2",
          "q_origin_key":"lan2",
          "alias":""
        },
        {
          "name":"lan3",
          "q_origin_key":"lan3",
          "alias":""
        }
      ],
      "span":"disable",
      "span-source-port":"",
      "span-dest-port":"",
      "span-direction":"both"
    }
  ],
  "vdom":"root",
  "path":"system",
  "name":"virtual-switch",
  "status":"success",
  "http_status":200,
  "serial":"FGT40xxxxxxxx",
  "version":"v7.2.5",
  "build":1517
}

option: 2
https://{ip_fgt}/api/v2/cmdb/system/switch-interface
#Suitable for olds revision (5.2.0- v5.2.15) i tested ))

{
  "http_method":"GET",
  "results":[
    {
      "name":"lan",
      "q_origin_key":"lan",
      "vdom":"root",
      "span-dest-port":"",
      "span-source-port":[
      ],
      "member":[
        {
          "interface-name":"internal1",
          "q_origin_key":"internal1"
        },
        {
          "interface-name":"internal2",
          "q_origin_key":"internal2"
        },
        {
          "interface-name":"internal3",
          "q_origin_key":"internal3"
        },
        {
          "interface-name":"internal4",
          "q_origin_key":"internal4"
        },
        {
          "interface-name":"internal5",
          "q_origin_key":"internal5"
        }
      ],
      "type":"switch",
      "span":"disable",
      "span-direction":"both"
    }
  ],
  "vdom":"root",
  "path":"system",
  "name":"switch-interface",
  "status":"success",
  "http_status":200,
  "serial":"FGTxxxxxxxx",
  "version":"v5.2.15",
  "build":766
}

Why in this case the redesigned function does not work., please tell me what the problem is..!?

function Get-FGTSystemVirtualSwitch {

    [CmdletBinding(DefaultParameterSetName = "default")]
    Param(
        [Parameter (Mandatory = $false, Position = 1, ParameterSetName = "name")]
        [string]$name,
        [Parameter (Mandatory = $false)]
        [Parameter (ParameterSetName = "filter")]
        [string]$filter_attribute,
        [Parameter (Mandatory = $false)]
        [Parameter (ParameterSetName = "name")]
        [Parameter (ParameterSetName = "filter")]
        [ValidateSet('equal', 'contains')]
        [string]$filter_type = "equal",
        [Parameter (Mandatory = $false)]
        [Parameter (ParameterSetName = "filter")]
        [psobject]$filter_value,
        [Parameter(Mandatory = $false)]
        [switch]$meta,
        [Parameter(Mandatory = $false)]
        [switch]$skip,
        [Parameter(Mandatory = $false)]
        [String[]]$vdom,
        [Parameter(Mandatory = $false)]
        [psobject]$connection = $DefaultFGTConnection
    )

    Begin {
    }

    Process {

        $invokeParams = @{ }
        if ( $PsBoundParameters.ContainsKey('meta') ) {
            $invokeParams.add( 'meta', $meta )
        }
        if ( $PsBoundParameters.ContainsKey('skip') ) {
            $invokeParams.add( 'skip', $skip )
        }
        if ( $PsBoundParameters.ContainsKey('vdom') ) {
            $invokeParams.add( 'vdom', $vdom )
        }

        #Filtering
        switch ( $PSCmdlet.ParameterSetName ) {
            "name" {
                $filter_value = $name
                $filter_attribute = "name"
            }
            default { }
        }

        #if filter value and filter_attribute, add filter (by default filter_type is equal)
        if ( $filter_value -and $filter_attribute ) {
            $invokeParams.add( 'filter_value', $filter_value )
            $invokeParams.add( 'filter_attribute', $filter_attribute )
            $invokeParams.add( 'filter_type', $filter_type )
        }

#        #with 5.2.x, it is a olds uri 
        if ($connection.version -le [version]"5.2.15") {
           $uri = 'api/v2/cmdb/system/switch-interface'
		   Write-Output "test1"
        } else {
          $uri = '/api/v2/cmdb/system/virtual-switch'
		  Write-Output "test2"
          }
#>
        Write-Output "test3"
        $response = Invoke-FGTRestMethod -uri $uri -method 'GET' -connection $connection @invokeParams
        $response.results
    }

    End {
    }
}

[alagoutte]

Hi @magarjoba

You need to remove extra first '/' to

uri = '/api/v2/cmdb/system/virtual-switch'

replace by

uri = 'api/v2/cmdb/system/virtual-switch'

and it will work (and no really need to support before FortiOS 6.0.x :D)

[magarjoba]

great...thanks, ...how could I miss such an error.. and not notice)))
in fact, I need support. I have a fleet of old devices..still left.
and this method of checking the ownership of interfaces. will help a lot, since the logic is ironclad, (meaning that the combined interfaces in the switch cannot be used separately.)
..and in browser policies it also works..

[alagoutte]

You can push a PR for add this cmdlet on next release !

[alagoutte]

@magarjoba do you plan to push a PR with this support ?

[alagoutte]

Added on #280