From 7424ad0c22d6d8a614e34c879d3b2dd229649701 Mon Sep 17 00:00:00 2001 From: Daniel Schaefer Date: Fri, 27 Jun 2025 15:05:58 +0800 Subject: [PATCH 1/2] clippy: Ignore uninlined_format_args See: https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args Recently introduced - I think it looks a bit messier inline. Signed-off-by: Daniel Schaefer --- framework_lib/src/lib.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/framework_lib/src/lib.rs b/framework_lib/src/lib.rs index 93d91e2b..05adf8fb 100644 --- a/framework_lib/src/lib.rs +++ b/framework_lib/src/lib.rs @@ -1,6 +1,7 @@ //! A library to interact with [Framework Computer](https://frame.work) hardware and building tools to do so. #![cfg_attr(feature = "uefi", no_std)] +#![allow(clippy::uninlined_format_args)] extern crate alloc; #[cfg(feature = "uefi")] From aa3638888d2606fb6f3e32c99a38fdb559fbb3b4 Mon Sep 17 00:00:00 2001 From: Daniel Schaefer Date: Fri, 27 Jun 2025 06:05:45 +0800 Subject: [PATCH 2/2] Current and charge rate limit cannot be read Signed-off-by: Daniel Schaefer --- framework_lib/src/commandline/clap_std.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/framework_lib/src/commandline/clap_std.rs b/framework_lib/src/commandline/clap_std.rs index 6d7f50ea..600efa74 100644 --- a/framework_lib/src/commandline/clap_std.rs +++ b/framework_lib/src/commandline/clap_std.rs @@ -167,14 +167,14 @@ struct ClapCli { #[arg(long)] charge_limit: Option>, - /// Get or set max charge current limit + /// Set max charge current limit #[arg(long)] - #[clap(num_args = ..=2)] + #[clap(num_args = 1..=2)] charge_current_limit: Vec, - /// Get or set max charge current limit + /// Set max charge current limit #[arg(long)] - #[clap(num_args = ..=2)] + #[clap(num_args = 1..=2)] charge_rate_limit: Vec, /// Get GPIO value by name or all, if no name provided