Unfinity >:( >:(

[Villawhatever]

Okay. so.

Unfinity breaks the usual "this is a funny set, so handle it as an uncard" paradigm. The set includes "acorn" cards, which all have an acorn-shaped holostamp, and "eternal" cards, which use the regular holostamp (or no stamp for less-than-rares). The acorn holostamp replaces silver-border. Eternal cards are real cards; they are playable in legacy, vintage, so on.

The problem is that any Unfinity card currently has set_type: funny, so even a real card like Saw in Half is discarded as an uncard. We also can't use border color as a determinant, because every card in the set has border: black. As far as I can tell, there is no good determinant in the current JSON.

So, we have a couple options:

1. We can hardcode the names of all of the "real" Unfinity cards and have a function that handles them before we hit the "discard this if it's a dumb card" check.
2. We can wait until scryfall has this sorted on their end such that there is a good determinant in the JSON, and then use that. Until then, we just handle every Unfinity card as an uncard
3. (Hopefully there's a 3, because those options both sort of suck)

[lunakv]

I thought of a few possible workarounds if we don't want to wait for option 2 (which we have at least like half a year to do still), but imo the most promising one I've been able to come up with is through checking legalities. If a defining characteristic of an uncard is that it's not legal anywhere except casual play, we can check whether a card from a funny set has a legality other than "not legal" in any format; if it does, it's not an uncard. Option 1 just sounds like some twisted sisyphean punishment.

[Villawhatever]

My only issue with checking legality that way is that it doesn't work in the lead time to the set being released. For instance, we already know Saw in Half is an eternal card, but it's still flagged as not_legal and will be for another 3+ months.

Still, if that's the only sane way to do this, then so be it.

[lunakv]

Which is a valid downside to that approach, but then again, most cards aren't previewed four months before release, so I propose this as a fallback in absence of a better solution.

[Fryyyyy]

Saw in Half has: "security_stamp": "oval",
Assembled Ensenble has: "security_stamp": "acorn",

[Villawhatever]

Surprised they got a fix in for that so quickly. That solves this easy enough then.

…

On Sun, Dec 19, 2021, 9:20 PM Fryyyyy ***@***.***> wrote: Saw in Half has: "security_stamp": "oval", Assembled Ensenble has: "security_stamp": "acorn", — Reply to this email directly, view it on GitHub <#179 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABSV4ZAFNOXDNBN6YV5EG4TUR2OGNANCNFSM5JCQDZKQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[lunakv]

Well, it almos solves it, but not quite fully. There will be cards that don't have any security stamps, and for those we still have to determine whether they're from an older funny set that didn't use silver border and so should be treated as uncards, or they're from a new funny set and shouldn't be.

[Villawhatever]

If it's from an older unset, it has border_color: silver. These are already handled.

If it's set:funny and no security stamp present, it has to be a "real" card. That's enough to cover Unfinity cards.

[lunakv]

If it's from an older unset, it has border_color: silver. These are already handled.

There are currently several exceptions to this. Contraptions for example are cards that are set_type: funny, don't have a silver border, and don't have a security stamp. Same goes for playtest cards, which even have security_stamp: oval atm for some reason, and Heroes of the Realm cards, which actually do have an oval security stamp.

We currently handle all these cards exclusively under !uncard. If we divide cards from funny sets purely on security stamp and assume no stamp means "not an uncard", they'll be reintroduced into the general card pool.