Host matching in fsconfig is too permissive

[r2evans]

If I have two hosts defined, something like

Host host
  blahblah
---
Host otherhost
  blahblah

and then call sshmount -w host, then it will bring in arguments from both host blocks.

Adding one more trailing --- to close out "otherhost" now results in no unique match!, which makes a little more sense, but two things then:

• Not having a --- on the last host should not cause different behavior, I think; and
• those two hosts are different, they should be treated differently

I suspect the issue is in fetchHostAttribute, looking.

[r2evans]

I think part of the reason you're having to jump through hoops in the functions is that you allow Host hostname to occur in the middle of its definition block. I suggest that if you tighten that so that the block must have that line as its first, then it will make parsing the file much easier and intuitive, mimicking the behavior more of SSH's config file (I believe).

[Fuseteam]

hmmm that's an odd one, i would expect host to pull from Host host to ---

[Fuseteam]

I think part of the reason you're having to jump through hoops in the functions is that you allow Host hostname to occur in the middle of its definition block. I suggest that if you tighten that so that the block must have that line as its first, then it will make parsing the file much easier and intuitive, mimicking the behavior more of SSH's config file (I believe).

oh i think this was to be able to mount by directory, in those cases i had no way to also get the hostname. the intention there was that would be last however, didn't consider in the middle iirc