Update CI to test installation with both GNU make and CMake

[tzanio]

This came up in #239

[justinlaughlin]

Right now it looks like CI already tests make/cmake for both ubuntu and macos. Is the goal for this to add make support to windows? Otherwise maybe we can close this one as complete

[v-dobrev]

Native Windows builds (i.e. not using cygwin, WSL, msys2, or something like that) with GNU make are not really possible. CMake is the way to go in this case. Therefore, on Windows, it should be sufficient to just test with CMake.

[justinlaughlin]

so should we close this?

[v-dobrev]

Post here what PR addresses this issue, and then it should fine to close this.

[justinlaughlin]

#189 is when cmake became the default in matrix. And the include section still has specific setups for different make tests

[v-dobrev]

The issue mentioned in the top post is about a bug in the install target. I'm not sure the PR you mention above deals with that -- do we have any tests in CI that run the install target in GNU make or CMake?

[justinlaughlin]

The issue mentioned in the top post is about a bug in the install target. I'm not sure the PR you mention above deals with that -- do we have any tests in CI that run the install target in GNU make or CMake?

Maybe I'm misunderstanding, but I thought we already test installation using both make and cmake for ubuntu and macos, and cmake for windows?

[v-dobrev]

I only see commands that build GLVis and then test it in the CI:

• build with GNU make:

  glvis/.github/workflows/builds.yml

  Lines 196 to 201 in ae4abfe

  	- name: build GLVis (make)
  	if: matrix.build-system == 'make'
  	run: |
  	glvis_target="opt"
  	[[ ${{ matrix.target }} == "dbg" ]] && glvis_target="debug";
  	cd glvis && make ${glvis_target} -j3

• build with CMake:

  glvis/.github/workflows/builds.yml

  Lines 203 to 221 in ae4abfe

  	- name: build GLVis (cmake)
  	if: matrix.build-system == 'cmake'
  	env:
  	VCPKG_DEFAULT_BINARY_CACHE: ${{ github.workspace }}/vcpkg_cache
  	run: |
  	build_type="Release"
  	[[ ${{ matrix.target }} == "dbg" ]] && build_type="Debug";
  	[[ ${{ matrix.os }} == "windows-latest" ]] \
  	&& toolchain_file="${VCPKG_INSTALLATION_ROOT}\\scripts\\buildsystems\\vcpkg.cmake"
  	cd glvis && mkdir build && cd build
  	cmake \
  	-D CMAKE_TOOLCHAIN_FILE:STRING=${toolchain_file} \
  	-D CMAKE_BUILD_TYPE:STRING=${build_type} \
  	-D ENABLE_TESTS:BOOL=TRUE \
  	-D mfem_DIR:PATH=${GITHUB_WORKSPACE}/${MFEM_TOP_DIR}/build \
  	-D GLVIS_BASELINE_SYS=${{ matrix.os }} \
  	..
  	cmake --build . --parallel 3 --config "${build_type}"
  	shell: bash

• test on Linux:

  glvis/.github/workflows/builds.yml

  Lines 240 to 245 in ae4abfe

  	- name: test GLVis (cmake/linux)
  	if: matrix.build-system == 'cmake' && matrix.os == 'ubuntu-latest'
  	run: |
  	cd glvis && cd build
  	xvfb-run -a ctest --verbose
  	tar czvf test_screenshots.tar.gz tests/test.*.png

• test on Mac:

  glvis/.github/workflows/builds.yml

  Lines 247 to 251 in ae4abfe

  	- name: test GLVis (cmake/mac)
  	if: matrix.build-system == 'cmake' && matrix.os == 'macos-latest'
  	run: |
  	cd glvis && cd build
  	ctest --verbose

I don't see anything that runs the install target.

[justinlaughlin]

When installed via cmake the install is being tested via tests/CMakeLists.txt which calls tests/glvis_driver.py which executes glvis using a stream file on line 129 .

When installed via make I'm not sure why but it just installs and doesn't test (maybe because the test is performed using cmake?).

We could update the testing to also work for make installations.

[v-dobrev]

I think you are confusing the build directory with the install directory. The commands in CI build GLVis in the build directory and run it from there. The target called install which performs the installation to the install directory is never run.

With CMake, the install directory is set with the flag -DCMAKE_INSTALL_PREFIX=<install-prefix> and in CI we currently actually do not set it (if not set, the default is a system path like /usr or /usr/local).

With GNU make, the install directory can be set with PREFIX=<install-prefix>/bin on the command line when running make install. The build directory with GNU make is the source directory -- we do not support out-of-source builds.

This issue is about adding a test that invokes the target called install -- there is such a target in both build systems.

Edit: fixed a typo "we support out-of-source builds" -> "we do not support out-of-source builds".