made ball chests animate properly. Tweak textures so insides is black and not a flash bang

Author: Waterpicker

common/src/main/java/generations/gg/generations/core/generationscore/common/world/container/GenericChestContainer.kt

@@ -10,12 +10,11 @@ import net.minecraft.world.entity.player.Player
 import net.minecraft.world.inventory.AbstractContainerMenu
 import net.minecraft.world.inventory.Slot
 import net.minecraft.world.item.ItemStack
-import java.io.Closeable
 
 open class GenericChestContainer(
     containerId: Int,
     val playerInventory: Inventory,
-    private val container: Container,
+    val container: Container,
     val inventoryWidth: Int,
     val inventoryHeight: Int,
     lock: (Int) -> Boolean = { false }, val onClosed: () -> Unit = {}
@@ -30,6 +29,7 @@ open class GenericChestContainer(
     val playerInventoryX: Int
 
     init {
+        container.startOpen(playerInventory.player)
         populate(container, 8, 16, 0, inventoryHeight, inventoryWidth)
         this.playerInventoryX = guiWidth / 2 - 80
         populatePlayer(playerInventory, playerInventoryX, guiHeight - 82, 1, 3, 9, lock)
@@ -60,9 +60,9 @@ open class GenericChestContainer(
         }
     }
 
-//    fun close() {
-//        container.instanceOrNull<CloseableContainer>()
-//    }
+    fun close() {
+        container.instanceOrNull<CloseableContainer>()?.close()
+    }
 
     private fun addSlot(container: Container, slot: Int, x: Int, y: Int) {
         this.addSlot(Slot(container, slot, x, y))
@@ -102,7 +102,7 @@ open class GenericChestContainer(
     override fun removed(player: Player) {
         super.removed(player)
         onClosed.invoke()
-//        container.stopOpen(player)
+        container.stopOpen(player)
     }
 
     open fun save(player: Player?) {}
@@ -116,7 +116,7 @@ open class GenericChestContainer(
             val row = buffer.readVarInt()
             val column = buffer.readVarInt()
 
-            return GenericChestContainer(containerId, playerInventory, SimpleContainer(row * column), row, column)
+            return GenericChestContainer(containerId, playerInventory, SimpleContainer(row * column), row, column,)
         }
     }
 }

common/src/main/java/generations/gg/generations/core/generationscore/common/world/container/GenericContainer.kt

@@ -44,7 +44,15 @@ object GenericContainer {
             object : ExtendedMenuProvider {
 
                 override fun createMenu(id: Int, inventory: Inventory, player: Player): AbstractContainerMenu {
-                    return GenericChestContainer(id, inventory, storage, width, height, if(lock != -1) { slot -> slot == lock } else { _ -> false }, onClose)
+                    return GenericChestContainer(
+                        id,
+                        inventory,
+                        storage,
+                        width,
+                        height,
+                        if(lock != -1) { slot -> slot == lock } else { _ -> false },
+                        onClose,
+                    )
                 }
 
                 override fun getDisplayName(): Component {

common/src/main/java/generations/gg/generations/core/generationscore/common/world/level/block/entities/generic/GenericChestBlockEntity.kt

@@ -1,7 +1,6 @@
 package generations.gg.generations.core.generationscore.common.world.level.block.entities.generic
 
 import generations.gg.generations.core.generationscore.common.client.render.rarecandy.instanceOrNull
-import generations.gg.generations.core.generationscore.common.orFalse
 import generations.gg.generations.core.generationscore.common.world.container.GenericChestContainer
 import generations.gg.generations.core.generationscore.common.world.container.GenericContainer
 import generations.gg.generations.core.generationscore.common.world.item.components.GenerationsDataComponents
@@ -17,7 +16,6 @@ import net.minecraft.network.chat.Component
 import net.minecraft.sounds.SoundEvent
 import net.minecraft.sounds.SoundEvents
 import net.minecraft.sounds.SoundSource
-import net.minecraft.world.CompoundContainer
 import net.minecraft.world.ContainerHelper
 import net.minecraft.world.entity.player.Inventory
 import net.minecraft.world.entity.player.Player
@@ -31,7 +29,7 @@ import net.minecraft.world.level.block.entity.RandomizableContainerBlockEntity
 import net.minecraft.world.level.block.state.BlockState
 
 @Suppress("deprecation")
-class GenericChestBlockEntity @JvmOverloads constructor(
+open class GenericChestBlockEntity @JvmOverloads constructor(
     arg: BlockPos,
     arg2: BlockState,
     private var width: Int = 9,
@@ -54,9 +52,7 @@ class GenericChestBlockEntity @JvmOverloads constructor(
         }
 
         override fun isOwnContainer(player: Player): Boolean {
-            val container = player.containerMenu.instanceOrNull<GenericChestContainer>() ?: false
-
-            return container == this@GenericChestBlockEntity || container.instanceOrNull<CompoundContainer>().orFalse { it.contains(this@GenericChestBlockEntity) }
+            return player.containerMenu.instanceOrNull<GenericChestContainer>()?.container == this@GenericChestBlockEntity
         }
     }
 
@@ -129,11 +125,7 @@ class GenericChestBlockEntity @JvmOverloads constructor(
     }
 
     override fun createMenu(containerId: Int, inventory: Inventory): AbstractContainerMenu {
-        return GenericChestContainer(containerId, inventory, this, width, height)
-    }
-
-    override fun setBlockState(blockState: BlockState) {
-        super.setBlockState(blockState)
+        return GenericChestContainer(containerId, inventory, this, width, height,)
     }
 
     fun recheckOpen() {