Merge Routes

[andodeki]

How does one merge routes for endpoints fn and path defines in seperate files and merged to the parent router.

[fakeshadow]

There is no provided method for merging routes. If any module want to mutate the App it has to take the ownership of it. The most plain way would be a function take in App and return it. For example:

use xitca_web::{handler::text::Text, route::get, App, NestApp};

fn main() -> std::io::Result<()> {
    let app = App::new();
    let app = foo::foo(app);
    let app = bar::bar(app);

    app.with_state("state")
        .serve()
        .bind("localhost:8080")?
        .run()
        .wait()
}

mod foo {
    use super::*;

    pub fn foo<C>(app: NestApp<C>) -> NestApp<C>
    where
        C: 'static,
    {
        app.at("/foo", get(Text("foo")))
    }
}

mod bar {
    use super::*;

    pub fn bar<C>(app: NestApp<C>) -> NestApp<C>
    where
        C: 'static,
    {
        app.at("/bar", get(Text("bar")))
    }
}

[andodeki]

right now i have this setup and i get an error, i need this clean handlers for the endpoints how can i achieve this?

pub type HandleResult<T> = Result<T, NError>;
pub type Request<B> = http::Request<RequestExt<B>>;
pub type Response = http::Response<Once<Bytes>>;
pub type Ctx<'a> = Context<'a, Request<RequestBody>, Arc<State>>;

pub async fn name(ctx: Ctx<'_>) -> Result<Response> {
    Ok(xitca_http::http::Response::builder())
}

pub async fn ping(ctx: Ctx<'_>) -> Result<Response> {
    Ok(xitca_http::http::Response::builder())
}

pub async fn start_xitca() -> (
    String,
    std::result::Result<Builder, std::io::Error>,
) {
    let app = App::new();
    let app = name_routes(app);
    let app = ping_routes(app);

    let service = app
        .with_state(app_state)
        .enclosed_fn(middleware)
        .enclosed(ContextBuilder::new(|| async { build_app().await }))
        .enclosed(HttpServiceBuilder::h1());

    let server = Builder::new().bind("service_name", "127.0.0.1:8080", service);
    ("127.0.0.1:8080".to_string(), server)
}
pub struct State {
    pub write_buf: RefCell<BytesMut>,
}
async fn build_app() -> Result<Arc<State>> {
    Ok(Arc::new(State {
        write_buf: Default::default(),
    }))
}
pub fn name_routes(app: NestApp<Arc<AppState>>) -> NestApp<Arc<AppState>> {
    app.at("/", get(handler_service(name)))
}

pub fn ping_routes(app: NestApp<Arc<AppState>>) -> NestApp<Arc<AppState>> {
    app.at("/v1/ping", get(handler_service(ping)))
}



pub async fn middleware<S>(
    service: &S,
    req: Ctx<'_>,
) -> std::result::Result<Response, core::convert::Infallible>
where
    S: for<'c> Service<Ctx<'c>, Response = Response, Error = RouterError<NError>>,
{
    let mut res = service.call(req).await.unwrap_or_else(error_handler);
    res.headers_mut().insert(SERVER, SERVER_HEADER_VALUE);
    Ok(res)
}

#[cold]
#[inline(never)]
fn error_handler(e: RouterError<NError>) -> Response {
    match e {}
}
fn error_response(status: StatusCode) -> Response {
    http::Response::builder()
        .status(status)
        .body(Once::new(Bytes::new()))
        .unwrap()
}

but i get this error

error[E0277]: `Context<'_, Request<RequestExt<RequestBody>>, Arc<State>>` does not impl FromRequest trait
   --> server/src/xictam2.rs:94:17
    |
94  |     app.at("/", get(handler_service(name)))
    |         --      ^^^^^^^^^^^^^^^^^^^^^^^^^^ handler function arguments must impl FromRequest trait
    |         |
    |         required by a bound introduced by this call
    |
    = help: the trait `for<'r> FromRequest<'_, xitca_web::WebContext<'r, Arc<State>>>` is not implemented for `Context<'_, Request<RequestExt<RequestBody>>, Arc<State>>`
    = note: consider add `impl FromRequest<_> for Context<'_, Request<RequestExt<RequestBody>>, Arc<State>>`
    = help: the following other types implement trait `FromRequest<'a, Req>`:
              `&'a Extensions` implements `FromRequest<'a, xitca_http::Request<Ext>>`
              `&'a HeaderMap` implements `FromRequest<'a, xitca_http::Request<Ext>>`
              `&'a HeaderMap` implements `FromRequest<'a, xitca_web::WebContext<'r, C, B>>`
              `&'a RequestExt<()>` implements `FromRequest<'a, xitca_web::WebContext<'r, C, B>>`
              `&'a std::net::SocketAddr` implements `FromRequest<'a, xitca_http::Request<RequestExt<B>>>`
              `&'a std::net::SocketAddr` implements `FromRequest<'a, xitca_web::WebContext<'r, C, B>>`
              `&'a xitca_http::Request<Ext>` implements `FromRequest<'a, xitca_http::Request<Ext>>`
              `&'a xitca_http::Request<RequestExt<()>>` implements `FromRequest<'a, xitca_web::WebContext<'r, C, B>>`
            and 44 others
    = note: required for `(Context<'_, Request<RequestExt<RequestBody>>, Arc<...>>,)` to implement `for<'r> FromRequest<'static, xitca_web::WebContext<'r, Arc<State>>>`
    = note: required for `HandlerService<fn(...) -> ... {name}, ..., ...>` to implement `for<'r> xitca_service::Service<xitca_web::WebContext<'r, Arc<State>>>`
    = note: 1 redundant requirement hidden
    = note: required for `RouteService<HandlerService<..., ..., ...>, ..., 1>` to implement `for<'r> xitca_service::Service<xitca_web::WebContext<'r, Arc<State>>>`
note: required by a bound in `App::<xitca_web::app::router::AppRouter<Obj>, CF>::at`
   --> /Users/aok/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/xitca-web-0.7.1/src/app/mod.rs:298:22
    |
295 |     pub fn at<F, C, B>(mut self, path: &'static str, builder: F) -> Self
    |            -- required by a bound in this associated function
...
298 |         F::Response: for<'r> Service<WebContext<'r, C, B>>,
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `App::<AppRouter<Obj>, CF>::at`
    = note: the full name for the type has been written to '/Users/aok/Projects/rustdev/MadeByMakepad/nimanyatta-server/target/release/deps/nimanyatta_server4-7b72f6ffa35c08b4.long-type-13530471453156903630.txt'
    = note: consider using `--verbose` to print the full type name to the console
error[E0277]: the trait bound `xitca_web::error::Error: From<NError>` is not satisfied
   --> server/src/xictam2.rs:94:17
    |
94  |     app.at("/", get(handler_service(name)))
    |         --      ^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `From<NError>` is not implemented for `xitca_web::error::Error`
    |         |
    |         required by a bound introduced by this call
    |
    = help: the following other types implement trait `From<T>`:
              `xitca_web::error::Error` implements `From<BodyOverFlow>`
              `xitca_web::error::Error` implements `From<Box<dyn StdError + Send + Sync>>`
              `xitca_web::error::Error` implements `From<ErrorStatus>`
              `xitca_web::error::Error` implements `From<ExtensionNotFound>`
              `xitca_web::error::Error` implements `From<HeaderNotFound>`
              `xitca_web::error::Error` implements `From<Infallible>`
              `xitca_web::error::Error` implements `From<MatchError>`
              `xitca_web::error::Error` implements `From<MethodNotAllowed>`
            and 9 others
    = note: required for `Result<Response<Once<Bytes>>, NError>` to implement `for<'r> Responder<xitca_web::WebContext<'r, Arc<State>>>`
    = note: required for `HandlerService<fn(...) -> ... {name}, ..., ...>` to implement `for<'r> xitca_service::Service<xitca_web::WebContext<'r, Arc<State>>>`
    = note: 1 redundant requirement hidden
    = note: required for `RouteService<HandlerService<..., ..., ...>, ..., 1>` to implement `for<'r> xitca_service::Service<xitca_web::WebContext<'r, Arc<State>>>`
note: required by a bound in `App::<xitca_web::app::router::AppRouter<Obj>, CF>::at`
   --> /Users/aok/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/xitca-web-0.7.1/src/app/mod.rs:298:22
    |
295 |     pub fn at<F, C, B>(mut self, path: &'static str, builder: F) -> Self
    |            -- required by a bound in this associated function
...
298 |         F::Response: for<'r> Service<WebContext<'r, C, B>>,
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `App::<AppRouter<Obj>, CF>::at`
    = note: the full name for the type has been written to '/Users/aok/Projects/rustdev/MadeByMakepad/nimanyatta-server/target/release/deps/nimanyatta_server4-7b72f6ffa35c08b4.long-type-15794606161945605145.txt'
    = note: consider using `--verbose` to print the full type name to the console

[fakeshadow]

Mixing xitca-web with xitca-http and xitca-server needs extra care and understanding because they are different level of abstraction. You can see xitca-web as a composer for latter low level crates and it's best you stay with it.

For example in your code App::with_state will desugar itself to an service with implicit ContextBuilder middleware. And if you add another layer on top of it the request type would become nested Context type which clearly is not what you want.

Or in other words remove your import of xitca-http and xitca-server and just use App::serve following with HttpServer::bind.

[andodeki]

i have this handler below, i need to same handler to accept both Json and Byte post request data. how can i implement this

async fn create_test(
    StateRef(state): StateRef<'_, Arc<AppState>>,
    Json(test): Json<CreateTest>,
    Byte(test): Byte<CreateTest>,
) -> StatusCode {

    StatusCode::NO_CONTENT

}