Merge pull request #17 from I-RzR-I/feature/Hide-Internal-Used-Extensions

I-RzR-I · web-flow · commit 6fffbc222b2a · 2023-08-03T01:45:29.000+03:00
Hide internal used extension
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -46,3 +46,6 @@
 
 ### **v.1.2.0.0** 
 -> Adjust JSON result/response property name (`result` => `response`).
+
+### **v.1.2.1.0** 
+-> Hide internal used extension.
diff --git a/src/AggregatedGenericResultMessage/Extensions/Common/NullExtensions.cs b/src/AggregatedGenericResultMessage/Extensions/Common/NullExtensions.cs
@@ -27,7 +27,7 @@ namespace AggregatedGenericResultMessage.Extensions.Common
     /// </summary>
     /// <remarks></remarks>
     [CodeSource("DomainCommonExtensions.CommonExtensions", "RzR", "RzR", 1)]
-    public static class NullExtensions
+    internal static class NullExtensions
     {
         /// <summary>
         ///     Is null
@@ -36,9 +36,6 @@ public static class NullExtensions
         /// <returns></returns>
         [CodeSource("https://github.com/I-RzR-I/DomainCommonExtensions", "RzR",
             "DomainCommonExtensions.CommonExtensions.NullExtensions.IsNull", 1)]
-        public static bool IsNull(this object obj)
-        {
-            return obj == null;
-        }
+        internal static bool IsNull(this object obj) => obj == null;
     }
 }
diff --git a/src/AggregatedGenericResultMessage/Extensions/Common/StringExtensions.cs b/src/AggregatedGenericResultMessage/Extensions/Common/StringExtensions.cs
@@ -29,7 +29,7 @@ namespace AggregatedGenericResultMessage.Extensions.Common
     /// </summary>
     /// <remarks></remarks>
     [CodeSource("DomainCommonExtensions.CommonExtensions", "RzR", "RzR", 1)]
-    public static class StringExtensions
+    internal static class StringExtensions
     {
         /// <summary>
         ///     Is Null or empty snippet
@@ -38,10 +38,7 @@ public static class StringExtensions
         /// <returns></returns>
         [CodeSource("https://github.com/I-RzR-I/DomainCommonExtensions", "RzR",
             "DomainCommonExtensions.CommonExtensions.StringExtensions.IsNullOrEmpty", 1)]
-        public static bool IsNullOrEmpty(this string str)
-        {
-            return string.IsNullOrEmpty(str);
-        }
+        internal static bool IsNullOrEmpty(this string str) => string.IsNullOrEmpty(str);
 
         /// <summary>
         ///     Cast string to enum value
@@ -52,7 +49,7 @@ public static bool IsNullOrEmpty(this string str)
         /// <remarks></remarks>
         [CodeSource("https://github.com/I-RzR-I/DomainCommonExtensions", "RzR",
             "DomainCommonExtensions.CommonExtensions.StringExtensions.ToEnum", 1)]
-        public static T ToEnum<T>(this string value)
+        internal static T ToEnum<T>(this string value)
         {
             if (value == null)
                 throw new ArgumentNullException(nameof(value));
@@ -73,7 +70,7 @@ public static T ToEnum<T>(this string value)
         /// <param name="plainText">Plain text</param>
         /// <returns></returns>
         /// <remarks></remarks>
-        public static string Base64Encode(this string plainText)
+        internal static string Base64Encode(this string plainText)
         {
             var plainTextBytes = Encoding.UTF7.GetBytes(plainText);
 
diff --git a/src/AggregatedGenericResultMessage/Extensions/Common/TExtensions.cs b/src/AggregatedGenericResultMessage/Extensions/Common/TExtensions.cs
@@ -31,7 +31,7 @@ namespace AggregatedGenericResultMessage.Extensions.Common
     /// </summary>
     /// <remarks></remarks>
     [CodeSource("DomainCommonExtensions.CommonExtensions", "RzR", "RzR", 1)]
-    public static class TExtensions
+    internal static class TExtensions
     {
         /// <summary>
         ///     Serialize source data to XML document
@@ -44,7 +44,7 @@ public static class TExtensions
         /// <remarks></remarks>
         [CodeSource("https://github.com/I-RzR-I/DomainCommonExtensions", "RzR",
             "DomainCommonExtensions.CommonExtensions.TExtensions.SerializeToXmlDoc", 1)]
-        public static XmlDocument SerializeToXmlDoc<T>(this T source, string rootName = null,
+        internal static XmlDocument SerializeToXmlDoc<T>(this T source, string rootName = null,
             string rootNameSpaceName = null)
         {
             if (source.IsNull()) return null;
diff --git a/src/shared/GeneralAssemblyInfo.cs b/src/shared/GeneralAssemblyInfo.cs
@@ -43,6 +43,6 @@
 
 [assembly: NeutralResourcesLanguage("en-US", UltimateResourceFallbackLocation.MainAssembly)]
 
-[assembly: AssemblyVersion("1.2.0.0")]
-[assembly: AssemblyFileVersion("1.2.0.0")]
-[assembly: AssemblyInformationalVersion("1.2.0.x")]
+[assembly: AssemblyVersion("1.2.1.0")]
+[assembly: AssemblyFileVersion("1.2.1.0")]
+[assembly: AssemblyInformationalVersion("1.2.1.x")]
diff --git a/src/tests/InfoResultTests/ErrorTests.cs b/src/tests/InfoResultTests/ErrorTests.cs
@@ -20,8 +20,8 @@
 using System.Linq;
 using AggregatedGenericResultMessage;
 using AggregatedGenericResultMessage.Enums;
-using AggregatedGenericResultMessage.Extensions.Common;
 using AggregatedGenericResultMessage.Extensions.Result.Messages;
+using DomainCommonExtensions.DataTypeExtensions;
 using InfoResultTests.Services;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
diff --git a/src/tests/InfoResultTests/FluentConfigurationTests.cs b/src/tests/InfoResultTests/FluentConfigurationTests.cs
@@ -19,10 +19,10 @@
 using System.Linq;
 using AggregatedGenericResultMessage;
 using AggregatedGenericResultMessage.Enums;
-using AggregatedGenericResultMessage.Extensions.Common;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using AggregatedGenericResultMessage.Extensions.Result;
 using AggregatedGenericResultMessage.Models;
+using DomainCommonExtensions.DataTypeExtensions;
 
 namespace InfoResultTests
 {
diff --git a/src/tests/InfoResultTests/InfoResultTests.csproj b/src/tests/InfoResultTests/InfoResultTests.csproj
@@ -10,6 +10,7 @@
 
   <ItemGroup>
     <PackageReference Include="Bogus" Version="34.0.2" />
+    <PackageReference Include="DomainCommonExtensions" Version="1.0.8.654" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.2.0" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.2.0" />
     <PackageReference Include="MSTest.TestAdapter" Version="2.2.10" />
diff --git a/src/tests/InfoResultTests/InfoTests.cs b/src/tests/InfoResultTests/InfoTests.cs
@@ -19,8 +19,8 @@
 using System.Linq;
 using AggregatedGenericResultMessage;
 using AggregatedGenericResultMessage.Enums;
-using AggregatedGenericResultMessage.Extensions.Common;
 using AggregatedGenericResultMessage.Extensions.Result.Messages;
+using DomainCommonExtensions.DataTypeExtensions;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 #endregion
diff --git a/src/tests/InfoResultTests/WarnTests.cs b/src/tests/InfoResultTests/WarnTests.cs
@@ -19,8 +19,8 @@
 using System.Linq;
 using AggregatedGenericResultMessage;
 using AggregatedGenericResultMessage.Enums;
-using AggregatedGenericResultMessage.Extensions.Common;
 using AggregatedGenericResultMessage.Extensions.Result.Messages;
+using DomainCommonExtensions.DataTypeExtensions;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 #endregion
diff --git a/src/tests/WebApplication/Services/LocalService.cs b/src/tests/WebApplication/Services/LocalService.cs
@@ -17,8 +17,7 @@
 using System;
 using AggregatedGenericResultMessage;
 using LocalSrv1;
-using AggregatedGenericResultMessage.Extensions;
-using AggregatedGenericResultMessage.Extensions.Common;
+using DomainCommonExtensions.CommonExtensions;
 
 namespace WebApplication.Services
 {
@@ -53,7 +52,7 @@ private LocalService()
             }
         }
 
-        public Result<LocalSrv1.Book> GetBook2(string id)
+        public Result<Book> GetBook2(string id)
         {
             try
             {
diff --git a/src/tests/WebApplication/WebApplication.csproj b/src/tests/WebApplication/WebApplication.csproj
@@ -6,6 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="DomainCommonExtensions" Version="1.0.8.654" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="5.0.17" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
     <PackageReference Include="System.ServiceModel.Duplex" Version="4.8.*" />

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ namespace AggregatedGenericResultMessage.Extensions.Common`
`27`	`27`	`/// </summary>`
`28`	`28`	`/// <remarks></remarks>`
`29`	`29`	`[CodeSource("DomainCommonExtensions.CommonExtensions", "RzR", "RzR", 1)]`
`30`		`- public static class NullExtensions`
	`30`	`+ internal static class NullExtensions`
`31`	`31`	`{`
`32`	`32`	`/// <summary>`
`33`	`33`	`/// Is null`
`@@ -36,9 +36,6 @@ public static class NullExtensions`
`36`	`36`	`/// <returns></returns>`
`37`	`37`	`[CodeSource("https://github.com/I-RzR-I/DomainCommonExtensions", "RzR",`
`38`	`38`	`"DomainCommonExtensions.CommonExtensions.NullExtensions.IsNull", 1)]`
`39`		`- public static bool IsNull(this object obj)`
`40`		`- {`
`41`		`- return obj == null;`
`42`		`- }`
	`39`	`+ internal static bool IsNull(this object obj) => obj == null;`
`43`	`40`	`}`
`44`	`41`	`}`