Sharing broken

[tdudgeon]

Sharing no longer works (either from IDE or in real system).
Click on the icon (padlock) and nothing changes.

And on this topic it might be worth thinking about moving this function into the Edit notebook dialog and having the icon just as a visual indicator?

[tdudgeon]

Turns out this is a usability issue, not a bug. The notebook was not sharable as it had no savoints. The problem was that there was nothing indicating this so it looked like sharing was not working.

To address this the idea of moving the sharing to the edit popup would make sense as that could provide feedback e.g. message saying notebook is not sharable.