Version 1.2.4 not working anymore on browsers

[Polve]

I upgraded my code to use the latest version of this library and while it still work fine under node, it stops working (it does not complete the connection) while running in the browser.

I think it has something to do with the way you handle the supported protocols but I've not yet been able to pinpoint exactly.

[JSteunou]

I had no issue upgrading to latest but if you can provide more info I would look into it

[Polve]

after some trial & error it seems like I'm able to use version 1.2.4 where I change this line:

headers['accept-version'] = getSupportedVersions(_this.ws.protocol);

with this one of a previous version:

headers['accept-version'] = VERSIONS.supportedVersions();

[JSteunou]

That's because you are not respecting the websocket protocols property. Look at this issue and associated fix #66

[JSteunou]

If you give a specific list of protocol at your websocket here https://github.com/JSteunou/webstomp-client/blob/master/src/webstomp.js#L12 or let the default list, your server must accept / handle at least one protocol in the list.

example from a real app:

the websocket request contains header Sec-WebSocket-Protocol: v10.stomp, v11.stomp, v12.stomp the response contains header sec-websocket-protocol: v12.stomp then the stomp CONNECT & CONNECTED frames contains accept-version:1.2 & version:1.2

[Polve]

I'm sorry, I'm not sure about where is the problem and what I've to do.

I've no control con the server, it's handled by https://docs.spring.io/spring-integration/reference/html/stomp.html and I suppose they follow specifications.
I was using default options and everything worked fine until 1.2.0, and stopped working in newer releases so I suppose some default is not correct.
That shouldn't happen, right?

[Polve]

So, to make it work, do I need to specify the exact protocol I want to use?

[JSteunou]

Could you show me how you initialize your webstomp client in JS and what are the headers you can see on the http request (the one upgraded as websocket) from your browser devtool for example.

[Polve]

I use a code like this:

const options = { debug: false, heartbeat: false }
stompClient = Stomp.client(stompEndpoint, options)

I'll look for the headers

[JSteunou]

ok that means that the client will send the default list of supported STOMP protocols 'v10.stomp', 'v11.stomp', 'v12.stomp' but maybe your server did not apply to this list and send another version back or worse, no version at all

[Polve]

I see, but that's one of the most used implementations so it's very bad to not work with it.

We can open an issue there if you find that their implementation is against specs.

And I can provide you (privately) a STOMP endpoint if you want to make some tests yourself

[JSteunou]

I will let you open an issue at spring project if there is an issue on their side, I will not have the time to handle all possible server implementation. I follow the spec and handle this client, that's enough for the little time I have for side projects :)

You did not tell me yet what is the http response header you get from your server.

[Polve]

Here is the response, do you need anything else?

[Polve]

The connection works fine if I use those options:

const options = { debug: false, heartbeat: false, protocols: ['v12.stomp'] }