Skip to content

[Enhancement/breaking change mitigation] Allow unbounded counts for tally in all scenarios #493

@MagmarFire

Description

@MagmarFire

v1.10.0's release stated the following in its patch notes:

Calling repeated or tally with a count of 0 is no longer supported outside of a measured
clause of a value expression. Doing so implies an unbounded hit requirement which cannot be
reached and is equivalent to always_false(). Using these to generate an AndNext/OrNext chain
was not intended. If you absolutely want to prevent the OrNext from being converted to alt groups
use the __ornext(condition) function. If you have a valid reason for forcing an AndNext chain
let me know.

I have a script that had been affected by this change, but I haven't really had a need to report the use case until now, where I have to fix an unrelated bug in the set.

The point of the affected achievement is to keep track of how many times a player has used attack commands and magic commands and reset the achievement if the player ever uses two more of one type over the other. To do this, I need to tally up uses of each command type via a hit target and then subtract them from a tally of the other. The code is below:

image

Since the player can use a theoretically-infinite number of attack commands and magic commands in the fight due to whiffs, tallies must be unbounded here. However, with the change introduced in v1.10.0, it appears that this is not allowed anymore.

A copy of the script is attached:
Kingdom Hearts Birth by Sleep Final Mix - Copy.rascript.txt

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions