Slacks switch to apps

[TechNosisDerek]

With Slacks switch to apps and away from custom integrations, are you interested in a rework of this?
Would you want the logic built in or would using a dependency like botman be acceptable? I'm not sure it would be needed for a simplish app like this but it could be nice.
Would adding something like a daily poll for users of the room to vote on the next page be a feature you would want?
Lastly, if I was to do all of those things would you care if I made changes so that the app was easier to deploy using docker and specifically caddy?

Thank you,
Derek

[randompherret]

To follow up with this after some playing around. I don't think botman will be needed

[JiFish]

Hi Derek

With Slacks switch to apps and away from custom integrations, are you interested in a rework of this?

Yes. This is something I have been meaning to look in to, but haven't for lack of time.

This would be helpful in regards to getting Storyteller on Discord too. At the moment the outgoing hook on Discord must be emulated using a seperate app with is far from ideal.

Would adding something like a daily poll for users of the room to vote on the next page be a feature you would want?

Sure, this would be a neat feature for larger servers.

Not quite sure how you would generate the options per page though? In many books your options are not always explicitly listed on the page. (Such as eating a ration in the Fighting Fantasy books, or changing weapons in Lone Wolf.) Still, I can see this being a cool feature for more basic choose-your-own-adventure style books.

Lastly, if I was to do all of those things would you care if I made changes so that the app was easier to deploy using docker and specifically caddy?

Sure thing, so long as docker doesn't become a requirement, I'm all for anything that will make Storyteller more useful to people.

I'll create a rework branch later today. Would you like to be added as collaborator or would you prefer to submit via pull requests?

Thank you for getting in touch!

[randompherret]

I started a fork and working on the feature here: https://github.com/randompherret/Storyteller/tree/feature/events_api_support
if you want to glance at it. so far all it can do is accept events but does nothing with them after that.
I also need to wrap it in a class and make it pretty. I'm still working full time so this might take me a bit. Once I have a working set I'll let you know if you want to test it out.

[randompherret]

I can work on your branch if you would prefer. I've never worked on someone else's stuff on github before, sorry for noobishness.

[JiFish]

However you are comfortable working is fine by me. I can push it upstream later. I'm hardly a github expert.

On that subject, apologies in advance for the slap-dash nature of the code. This is very much a project that grew from a single use script.

[randompherret]

Well, its been a fun two weeks. I got to learn how namespaces, and classes, and all manner of things work. Previous programming I did was all in a framework. Its nice being able to do this from scratch.

I have a working page that can take commands from slack, and then act on them. All I have working at the moment is help and dice roller. I know the rulesets you wrote will need to be converted but I hope to not need to change the book files at all. It is more of a re-work then I intended but I think it makes the code more extendable and easier to add books / rules to.
Still todo:
Load rules based on config file
Move response queue to subclasses
move command processing to subclass
implement character creation
other things I am sure I am forgetting

Take a look and let me know if you say any red flags.

[JiFish]

Thanks, I'll try to find time to look at this during the week.

[JiFish]

@randompherret

Apologies for taking so long to get back to you, I've had a lot on my plate.

I've taken a look through the new branch and I am very impressed. However, there is one thing that gives my cause for concern: You are already looking to refactor the rulesets part of the code.

I'm going to gently suggest this might be a mistake and your first goal should be getting the new network code working with the existing game rules code.

At that point you'll already have a much better version than I currently have and - most importantly - it will be fully operational. After that, by all means go back and refactor the ruleset stuff too.

The rulesets themselves are easily the most complex, convoluted and undocumented bit of the code. (You may have to actually referrer to the books themselves to figure out how it should be working.) I think by refactoring now you will creating an extra barrier to producing an improved working version. The end user, after all, does not care that the game rules are easier to extend.