🛡️ Sentinel: [CRITICAL] Fix arbitrary command execution in Rhai scripts

[JustinWoodring]

🛡️ Sentinel: [CRITICAL] Fix arbitrary command execution in Rhai scripts

🚨 Severity: CRITICAL
💡 Vulnerability: The shell_execute function in the Rhai scripting engine allowed execution of arbitrary shell commands (e.g., echo, ls, etc.) if a script was modified or injected.
🎯 Impact: An attacker with script editing privileges (or if a script injection vulnerability existed) could execute arbitrary code on the server, potentially compromising the entire system.
🔧 Fix: Implemented an allowlist in slatron-server/src/rhai_engine/mod.rs that restricts shell_execute to only yt-dlp, ffmpeg, and ffprobe. Attempts to run other commands now return a security error (code: -1).
✅ Verification: Added unit tests in slatron-server/src/rhai_engine/security_test.rs to confirm:
1. echo (arbitrary command) is blocked.
2. yt-dlp (allowed command) is permitted.

---

PR created automatically by Jules for task 4956394237584817752 started by @JustinWoodring

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[claude]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.