π‘οΈ Sentinel: [CRITICAL] Fix command injection in slatron-node#36
π‘οΈ Sentinel: [CRITICAL] Fix command injection in slatron-node#36JustinWoodring wants to merge 1 commit intomainfrom
Conversation
π¨ Severity: CRITICAL π‘ Vulnerability: Command Injection in `shell_execute` via `sh -c` π― Impact: RCE on display nodes π§ Fix: Replaced `sh -c` with `Command::new` using custom tokenizer and strict allowlist. β Verification: `cargo test -p slatron-node` passes. New security tests added. Co-authored-by: JustinWoodring <41842051+JustinWoodring@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses a critical command injection vulnerability in
slatron-node'sshell_executeRhai function.Previously,
shell_executepassed the user-provided command string directly tosh -c, allowing arbitrary command execution via shell operators (e.g.,;,|,$()).The fix:
sh -cusage: Commands are now executed directly usingstd::process::Command, preventing shell interpretation.yt-dlp,ffmpeg,ffprobe, andechoare allowed to run.tokenize_commandsplits the command string into executable and arguments while respecting quotes, ensuring arguments are passed correctly without shell expansion.--execinyt-dlpto prevent application-level RCE.security_test.rsverifies that injection attempts fail and valid commands work as expected.PR created automatically by Jules for task 2193104580598987903 started by @JustinWoodring