🛡️ Sentinel: [CRITICAL] Fix RCE in Rhai shell_execute#37
🛡️ Sentinel: [CRITICAL] Fix RCE in Rhai shell_execute#37JustinWoodring wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: JustinWoodring <41842051+JustinWoodring@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Implemented an allowlist for the
shell_executefunction inslatron-serverto restrict execution toyt-dlp,ffmpeg, andffprobe. Added specific blocking foryt-dlparguments starting with--execto prevent arbitrary command execution. Added security tests to verify the fix.PR created automatically by Jules for task 9818630613815758807 started by @JustinWoodring