Link texts and descriptions generated from the metadata

[javagl]

I noticed this in the context of #248 , but it is unrelated to that PR. I started it as a comment, but became long enough to be summarized in an issue. (I didn't thoroughly review everything that was previously added to this repo)

Mainly @DRx3D :

There is an array of predefined licenses in the modelmetadata.php. The elements have properties icon, link, text and spdx. For example the text for "CC-BY-4.0 International" is

"CC-BY 4.0 International".

This appears as the link text in the "Legal" section of the generated README.md.

For Khronos (and some other licenses), that text says

"Khronos Trademark or Logo"

which looks a bit odd as a link text.

There also are some other glitches. For example, in that linked README.md, there is that bullet point

• Non-copyrightable logo for Khronos logo

which apparently generated from the metadata from a pattern like

• artist for what

A broader question could be about the role of the LicenseRef-LegalMark-Khronos, which is apparently used in cases where something "non-copyrightable" is involved. This is also used as the spdx, but it is not one of the SPDX identifiers listed at https://spdx.org/licenses/ , which may raise questions.

[DRx3D]

I an not quite sure where or what the specific question is, so I'm going with discussion.

Trademarks and copyrights are owned IP. Creative material is (usually) copyrighted. Trademarks are usually not copyrighted. These confer differing types and levels of protection. The Khronos trademarks glTF (R) cannot be copyrighted because there is no creative content. It can (and is) trademarked. The glTF logo ("glTF" text with a oval swish) is a trademark. There is some ambiguity in Khronos exactly how that should be listed.

The various logos used in models will never be listed in the SPDX license list because they are not open source. To my knowledge all of the logos are trademarked. That carries a set of usage rules that are not open source. The Khronos marks have a specific set of allowable use requirements (see 'Visual Integrity' section of the "Khronos Official Logo Usage Guidelines" link at https://www.khronos.org/legal/trademarks/). The Guidelines allow use in open source models without conferring open source licensing to the logo.

In writing this, I noticed that many (perhaps most or all) of the license links are broken. For example, the Khronos license should link to https://github.com/KhronosGroup/glTF-Sample-Assets/blob/main/LICENSES/LicenseRef-LegalMark-Khronos.txt and the License listing with each model should link to the LICENSE.md file for that model.

[javagl]

It's somewhere between "discussion", "clarification" (of legal aspects and the intent behind certain aspects of the current PHP), and possible fixes. Again: I have not thoroughly reviewed everything - I just stumbled over some oddities, and tried to make sense of them.

---

I was surprised by the link text "Khronos Trademark or Logo". But this may to some extent be caused by that link not leading anywhere (as you now also mentioned). If this link led to the /LICENSES/LicenseRef-LegalMark-Khronos.txt, then this would explain the link text.

To my understanding, this should be a fairly trivial fix, by inserting the right relative path at

glTF-Sample-Assets/util/modelmetadata.php

Line 194 in f420778

'link'=>'',

(similar for all other "referenced" licenses).

I think that in addition to that, changing the link text to something like
"Khronos Trademark and Logo Usage Guidelines"
could make that clearer. (Even though this is a matter of the metadata JSONs)

---

The strange wording of the bullet point,
"Non-copyrightable logo for Khronos logo"
could probably be fixed as well A quick shot: Maybe leaving the artist empty could skip the generation of that
"artist for what"
part? Right now, this is treated as an error. Whether that entry should, must, may, must not, or should not have the "©" prefix when the logo is not actually copyrightable is something that I don't want to dive in right now.

---

The various logos used in models will never be listed in the SPDX license list because they are not open source.

That was not the point. The point is that the property name "spdx" suggests that this is an SPDX ID (and in most cases, it is). When it can be ~"an 'arbitrary' string that is resolved by the PHP code", then it could be called differently. The current submission guidelines (way at the bottom) do not explain the spdx field. (You know what will happen - people will copy and paste...)