Skip to content

Add some null checks to UpdateGraphicsUniforms() #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Clayell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add some null checks to UpdateGraphicsUniforms() #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scatterer/Effects/Proland/Atmosphere/SkyNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ public void OnPreRender()

public void UpdateGraphicsUniforms()
{
if (!inScaledSpace && !MapView.MapIsEnabled && postprocessingEnabled && localScatteringContainer!=null)
if (!inScaledSpace && !MapView.MapIsEnabled && postprocessingEnabled && localScatteringContainer != null)
{
UpdatePostProcessMaterialUniforms (localScatteringContainer.material);
}
Expand All @@ -269,7 +269,7 @@ public void UpdateGraphicsUniforms()
UpdateSunflareExtinctions ();
}

if (scaledScatteringContainer != null)
if (scaledScatteringContainer != null && scaledScatteringContainer.MeshRenderer != null)
scaledScatteringContainer.MeshRenderer.enabled = stockScaledPlanetMeshRenderer.enabled;

if (localScatteringContainer != null)
Expand All @@ -290,7 +290,9 @@ public void UpdateGraphicsUniforms()

scaledEclipseMaterial.SetMatrix (ShaderProperties.lightOccluders1_PROPERTY, castersMatrix1);
scaledEclipseMaterial.SetMatrix (ShaderProperties.lightOccluders2_PROPERTY, castersMatrix2);
scaledEclipseMaterial.SetVector (ShaderProperties.sunPosAndRadius_PROPERTY, new Vector4 (sunPosRelPlanet.x, sunPosRelPlanet.y,

if (prolandManager.sunCelestialBody != null)
scaledEclipseMaterial.SetVector (ShaderProperties.sunPosAndRadius_PROPERTY, new Vector4 (sunPosRelPlanet.x, sunPosRelPlanet.y,
sunPosRelPlanet.z, (float)prolandManager.sunCelestialBody.Radius));
}
}
Expand Down