Notify on full Cargo Hold

[NabilZaman]

When AFK salvaging it would be really useful to notify when the cargo hold is full. I'm kind of surprised this isn't a feature yet and I'd be happy to take a crack and implementing it.

I could imagine that it's annoying to be notified when you intentionally fill up your cargo, so maybe the ideal feature would limit the notification to only after a salvage has been acquired by a crewmate, but I don't feel like your cargo hold fills up often outside of salvaging or trawling and either case seems reasonable to want to get a notification.

Anyway, curious to hear others' thoughts, especially if (as I sort of expect) some feature like this already exists and it's just hidden somewhere I haven't been able to find?

[BBeeaarr]

If you'd like to take a crack at it here is the relevant LOC: https://github.com/dekvall/sailing/blob/ea08b2108bfb335779d3bd232efeeac78a7156ae/src/main/java/com/duckblade/osrs/sailing/features/facilities/CargoHoldTracker.java#L198

It looks like the logic is already there via MSG_CREWMATE_SALVAGES and MSG_CREWMATE_SALVAGE_FULL checks in the linked function

[NabilZaman]

Thanks for the pointer, I'll start looking at this now.

I am now of the opinion that the cleaner behavior is just to notify on the cargo hold becoming full for any reason (if the user opts-in, default false). Ie. on the state transition cargo hold has capacity -> cargo hold capacity is 0.

I think that is the simplest and is expressed most easily in the plugin configuration.