Skip to content

feat: add unit tests for reentrant get #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchalamet merged 1 commit into from
Jan 31, 2026
Merged

feat: add unit tests for reentrant get #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/Terrabuild.PubSub.Tests/Hub.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module Terrabuild.PubSub.Tests
open NUnit.Framework
open FsUnit
open System.Threading
open System.Threading.Tasks


[<Test>]
Expand Down Expand Up @@ -280,3 +281,23 @@ let subscribing_after_error_is_noop() =

triggered.Wait(100) |> should equal false
triggeredBg.Wait(100) |> should equal false


[<Test>]
let reentrant_get_in_callback_does_not_deadlock() =
use hub = Hub.Create(1)

let signal = hub.GetSignal<int> "reentrant"

let mutable triggered = false
hub.Subscribe "reentrant-sub" [ signal ] (fun () ->
signal.Get<int>() |> should equal 7
triggered <- true)

signal.Set(7)

let waitTask = Task.Run(fun () -> hub.WaitCompletion())
waitTask.Wait(500) |> should equal true

waitTask.Result |> should equal Status.Ok
triggered |> should equal true