Skip to content

Update package.json, add package-lock.json, remove unused watch task #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arzafran wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update package.json, add package-lock.json, remove unused watch task #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,11 +336,6 @@ gulp.task('run', ['clean', 'serve'], function() {
gulp.watch(config.folderDev.js + '/*.js').on('change', browserSync.reload);
});

// Watch for changes
gulp.task('watch', ['build'], function() {
Copy link

@ghost ghost Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this removal is correct as it was practically duplicated. I'd love to have some 'watch only' feature without the 'serve'. Since there were times I needed to add PHP to the project and work through Apache (opening the project in the browser as http://localhost), the 'serve' in my case was useless, yet the watch is a great thing to have, so you can see the changes by manually refreshing.
Nice change, maybe at some point we can rearrange the tasks having 'run' for build, watch and serve and another task 'watch' as build and watch only (maybe 'run' may call 'watch' and 'serve').

gulp.watch(config.folderAssets.base + '/**/*.scss', ['sass']);
});

// Define task to deploy to SFTP server
gulp.task('deploy', ['build'], function() {
return gulp.src([config.folderDev.base + '/**/*.*', '!./dev/js/vendor/**'])
Expand Down
Loading