Add support for X1800 (and other?) mixers

[MarByteBeep]

As described here: #4 When trying to connect to a mixer, the code crashes.

So the code needs to bypass the mixer, either by skipping result.source === "DN-X1800Prime" or by actually implementing support for it. But for that, I need to know what exactly is crashing. @honusz can you help me out with more info on this?

[honusz]

This is a case where the Go-stagelinq code has the same issue:

StageLinq-ts

[15:39:13] [INFO] Found 'DN-X1800Prime' Controller at '192.168.2.248:50010' with following software: { name: 'JM08', version: '1.00' }
[15:39:21] [ERROR] Error: Failed to connect to '192.168.2.248:50010'
    at c:\Users\honusz\code\StageLinq\dist\utils\tcp.js:12:15
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Object.connect (c:\Users\honusz\code\StageLinq\dist\utils\tcp.js:11:5)
    at async Controller.connect (c:\Users\honusz\code\StageLinq\dist\Controller.js:73:27)
    at async main (c:\Users\honusz\code\StageLinq\dist\main.js:29:5)
    at async c:\Users\honusz\code\StageLinq\dist\main.js:76:9

Go-StageLinq

2022/01/09 16:33:56 192.168.2.248 "DN-X1800Prime" "JM08" "1.00"
2022/01/09 16:33:56 	attempting to connect to this device…
2022/01/09 16:33:58 WARNING: dial tcp 192.168.2.248:50010: connectex: No connection could be made because the target machine actively refused it.

I've attached a capture of SoundSwitch connecting with the X1800. I see a few interesting things:

• The go and ts code both try to connect to port 50010 on the x1800, and are refused.
• It looks (and maybe I'm wrong about this) like the x1800 actually initiates the connection after reading the announcement from Soundswitch (packet 15)?
• Soundswitch uses the port the x1800 reached out from (49156) to reply.
• At packet 21, they agree to move to port 49517 (this doesn't seem like an error or anything, it happened when I tried again at roughly the same point in the sequence).
  soundswitchcapture-filtered.zip

[MarByteBeep]

Thanks for this! I'll just write down here the stuff that I notice in that capture:

X1800 = .248
SS    = .16

P1-P12
X1800 announces itself @ port 0xc35a = 50010

P13
SoundSwitch announces itself @ port 0xe0f3 = 57587

P15-P16
I assume port 49156 is randomly chosen by X1800 and it tries to initiate connection to port 57587 of the SoundSwitch, as was broadcast in P13.

P17
X1800 sends ServiceRequest message to SS, followed by 00 00 00 00 00 00 00 00 80 00 00 05 95 01 ab 6f
I have no idea yet what those numbers are and if they are in any way important.

P18
SoundSwitch sends code 0x0000 0001 to X1800, which I believe is a 64 bit timestamp, not interesting

P19
X1800 -> SoundSwitch, now this one is interesting. Here a timestamp is also sent back to the SoundSwitch, but the 00 00 00 00 00 00 00 00 80 00 00 05 95 01 ab 6f pattern of P17 is also included in that message. No clue as to why.

P20
SS -> X1800. This one is a ServiceRequest message, now from the SoundSwitch back to the X1800.
But this is different from what i've seen so far. The Go code and my code just send 0x0000 0002 + a 16 byte token, but this packet shows a whole lot more. I need to try to see what's in there.

P21
Suddenly the communication has moved one port up => 49157. Why? 49157 = 0xC004, but I haven't seen that number in P20. Perhaps it's just always 1 up. Could you verify?

That's it for tonight. I'll look further tomorrow!

[honusz]

X1800 sends ServiceRequest message to SS, followed by 00 00 00 00 00 00 00 00 80 00 00 05 95 01 ab 6f
I have no idea yet what those numbers are and if they are in any way important.

Yeah, I've seen some weird ones with leading FF FF FF FF FF FF as well. It looks like, a mask? or flags? Maybe the token isn't really a token. Is that just an assumption IceDream made? Definitely something to look into more.

Could you verify?

Yup, it happens every session, even with other StageLinq software that connects to x1800.

Suddenly the communication has moved one port up => 49157. Why? 49157 = 0xC004, but I haven't seen that number in P20. Perhaps it's just always 1 up.

It looks like P21 is opening a new connection (SYN flag), acknowledged by the client in P22. My guess is, regardless of the port specified in the Discovery Announcement, if the device sends the first message (as in this case), the client knows to respond on that port, and if that port changes, it knows to follow it.
We could do the same, we'd need to pass socket.remotePort down to the messageHandler I guess.

[honusz]

Interesting discovery: The X1800 actually passes the volume levels from the mixer to the SC6000s. So if you adjust volume levels on the mixer (either by the channel faders, or the crossfader), it's readable directly from the SC6000's statemap (much like with Prime 2/4/Go I imagine.)

I'm not sure what other information from the mixer is useful for us. Some StageLinq software, if it bothers to connect to the mixer at all, is just sending timestamps back and forth.

[MarByteBeep]

I'm a bit confused: that screenshot looks like NodeJS output, so did the X1800 succeed in connecting to the PC client?

[honusz]

I'm a bit confused: that screenshot looks like NodeJS output, so did the X1800 succeed in connecting to the PC client?

Oh no, sorry, to clarify;
That is from Node, but connected the SC6000, however, that value updates when I move the fader on the x1800.
So Sc6000 is using its own connection to retrieve that value and hold it in the state map.

[MarByteBeep]

@honusz ok this is interesting. It would mean that we really don't need to connect to the X1800, right? If the fader information is already propagated to the SC6000's as well. In fact, adding support for the mixer, could only complicate things, since I'd have to filter out double fader info.

Or is there information sent from the X1800 that is needed and not sent through the SC6000's? Can you see that in WireShark?

[MarByteBeep]

@honusz and @kkirjala can you test the listen branch again, which is now full of WIP code ;) This is what I changed:

"Initial stab at connecting multiple devices. Cannot test without having multiple devices. One known issue: I cannot seem to reconnect a once lost device properly. I get a requestServices timeout. Need WireShark info for that."

I'd love to know the results on your multi device setups. And if the mixer gives you trouble, simply add the source name to EXCLUDE_DEVICES in common.ts and retry. As I mentioned in my previous post: perhaps we don't even need to connect to that mixer.

@honusz would you be able to make a WireShark profile for me of those devices trying to connect to the app?

[honusz]

I'd love to know the results on your multi device setups. And if the mixer gives you trouble, simply add the source name to EXCLUDE_DEVICES in common.ts and retry.

Everything working great, though I did get an UnhandledPromiseRejectionWarning when I tried disconnecting and reconnecting the mixer.
Interestingly though; it wasn't a fatal crash. I stopped Wireshark capture, but forgot to disconnect the debugger. According to the debugger output, it was able to reconnect to the device after 10 minutes.
This is actually something I've seen before, while working on my FileTransfer fix; It seems like the SC6000 (and maybe all Denon devices? v2.1.1 at least?) possibly detects misbehaving software, and puts the offender on a timeout.

I'll see if I can reproduce this (and leave Wireshark capturing this time), but here's my logs for now.
0bbed38-capture-filtered.pcapng.zip
0bbed38-debug_log.txt

Just as a note, the pcap is filtered with (ip.addr == 192.168.2.143 && tcp) || ((ip.addr == 192.168.2.144 && tcp)) || (udp.port == 51337 && ip.addr != 192.168.2.248), which is just capturing tcp packets to/from player1(..2.143) && player2 (..2.144), udp messages on the discovery port excluding those from the x1800 (..2.248).
I also suppressed console.log messages from statemap for log brevity.
If you'd prefer I use less filter, and leave code untouched, just lmk =)

[honusz]

I modified controller.connect() to handle the promise rejection, and now it's able to reconnect to the controller and statemap no problem.
It is still assigning new id during the reconnection, but at least it's not being timed out by the controller.

try {
	await this.requestAvailableServices();
} catch (err) {
	console.error(err)
} finally {
	return this.servicePorts
}

0bbed38-02-filtered.pcapng.zip
0bbed38-02-debug_log.txt

[honusz]

Should we consider enabling Discussions for this repo? Just wondering if these issues will get a bit off-topic of numerous.
I've done a bunch of digging into the timestamp messages and have some interesting findings, but I'm not sure if I should create a new issue to discuss it.

[MarByteBeep]

@honusz awesome idea, I just added the discussions section. Feel free to start a new discussion there. It helps keeping these issues clean

[kkirjala]

@honusz and @kkirjala can you test the listen branch again, which is now full of WIP code ;) This is what I changed:

"Initial stab at connecting multiple devices. Cannot test without having multiple devices. One known issue: I cannot seem to reconnect a once lost device properly. I get a requestServices timeout. Need WireShark info for that."

I'd love to know the results on your multi device setups. And if the mixer gives you trouble, simply add the source name to EXCLUDE_DEVICES in common.ts and retry. As I mentioned in my previous post: perhaps we don't even need to connect to that mixer.

I can confirm that the current listen branch (commit 0bbed38) is able to detect both of my SC5000 players, connect to them and receive load track/BPM change/external mixer volume change events from all layers (4 in total).