Merge pull request #120 from MarkDerman/ResultFixes-Mark

ResultFixes-Mark

Author: MarkDerman

DesignContracts/Core/Contract.cs

@@ -108,7 +108,7 @@ private static void ReportFailure(ContractFailureKind kind, string? userMessage,
 
         private static string BuildFailureMessage(ContractFailureKind kind, string? userMessage, string? conditionText)
         {
-            string kindText = kind.ToStringFast();
+            string kindText = kind.ToString();
 
             if (!string.IsNullOrWhiteSpace(userMessage) && !string.IsNullOrWhiteSpace(conditionText))
             {

DesignContracts/Core/ContractFailureKind.cs

@@ -1,11 +1,9 @@
-using NetEscapades.EnumGenerators;
 
 namespace Odin.DesignContracts
 {
     /// <summary>
     /// Defines the semantic category of a design contract failure.
     /// </summary>
-    [EnumExtensions]
     public enum ContractFailureKind : short
     {
         /// <summary>

DesignContracts/Core/Odin.DesignContracts.csproj

@@ -11,10 +11,6 @@
         <WarningsAsErrors>1591;1573;</WarningsAsErrors> <!-- Not to be removed. Documentation is required. -->
     </PropertyGroup>
 
-    <ItemGroup>
-        <PackageReference Include="NetEscapades.EnumGenerators" Version="1.0.0-beta16"/>
-    </ItemGroup>
-
     <ItemGroup>
         <None Include="icon.png" Pack="true" PackagePath=""/>
     </ItemGroup>

System/Result/ResultOfTMessage.cs

@@ -60,7 +60,7 @@ public Result()
         /// Result constructor.
         /// </summary>
         /// <param name="isSuccess">True or False</param>
-        /// <param name="message">Optional message. Best practice is to include at least 1 message for failed operations however.</param>
+        /// <param name="message">Optional message. Best practice is to include at least 1 message for failed operations, however this is not enforced.</param>
         public Result(bool isSuccess, TMessage? message = null)
         {
             IsSuccess = isSuccess;
@@ -75,7 +75,7 @@ public Result(bool isSuccess, TMessage? message = null)
         /// Result constructor.
         /// </summary>
         /// <param name="isSuccess">True or False</param>
-        /// <param name="messages">Optional message. Best practice is to include at least 1 message for failed operations however.</param>
+        /// <param name="messages">Optional messages. Normal practice is to include at least 1 message for failed operations.</param>
         public Result(bool isSuccess, IEnumerable<TMessage>? messages)
         {
             IsSuccess = isSuccess;
@@ -86,7 +86,7 @@ public Result(bool isSuccess, IEnumerable<TMessage>? messages)
         }
 
         /// <summary>
-        /// Failure
+        ///  Creates a failed result (IsSuccess==false) with a message.
         /// </summary>
         /// <param name="message"></param>
         /// <returns></returns>
@@ -96,7 +96,7 @@ public static Result<TMessage> Failure(TMessage message)
         }
 
         /// <summary>
-        /// Creates a Failure outcome with messages.
+        /// Creates a failed result (IsSuccess==false) with messages.
         /// </summary>
         /// <param name="messages"></param>
         /// <returns></returns> 

System/Tests/ResultOfTMessageTests.cs

@@ -9,6 +9,7 @@ namespace Tests.Odin.System
     [TestFixture(typeof(MessageSeverity))]
     public sealed class ResultOfTMessageTests<TMessage> where TMessage : class
     {
+
         [Test]
         public void Success()
         {