Build error with gcc 14

[rafael2k]

When trying to build TLVC by running "build.sh", I get:

gcc -DHAVE_CONFIG_H -I. -I../../binutils-src/gas  -I. -I../../binutils-src/gas -I../bfd -I../../binutils-src/gas/config -I../../binutils-src/gas/../include -I../../binutils-src/gas/.. -I../../binutils-src/gas/../bfd -DLOCALEDIR="\"/home/rafael2k/programs/devel/TLVC/cross/share/locale\""  -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Wstack-usage=262144 -Werror -Wwrite-strings -I../../binutils-src/gas/../zlib -g -O2 -MT write.o -MD -MP -MF $depbase.Tpo -c -o write.o ../../binutils-src/gas/write.c &&\
mv -f $depbase.Tpo $depbase.Po
../../binutils-src/gas/write.c: In function ‘chain_frchains_together’:
../../binutils-src/gas/write.c:426:7: error: dangling pointer ‘prev_frag’ to ‘dummy’ may be used [-Werror=dangling-pointer=]
  425 |     info->frchainP->frch_last
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~
  426 |       = chain_frchains_together_1 (section, info->frchainP);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-src/gas/write.c:391:9: note: ‘dummy’ declared here
  391 |   fragS dummy, *prev_frag = &dummy;
      |         ^~~~~
cc1: all warnings being treated as errors
make[5]: *** [Makefile:1224: write.o] Error 1
make[5]: Leaving directory '/home/rafael2k/programs/devel/TLVC/cross/build/binutils-build/gas'
make[4]: *** [Makefile:1269: all-recursive] Error 1
make[4]: Leaving directory '/home/rafael2k/programs/devel/TLVC/cross/build/binutils-build/gas'
make[3]: *** [Makefile:814: all] Error 2
make[3]: Leaving directory '/home/rafael2k/programs/devel/TLVC/cross/build/binutils-build/gas'
make[2]: *** [Makefile:4864: all-gas] Error 2
make[2]: Leaving directory '/home/rafael2k/programs/devel/TLVC/cross/build/binutils-build'
make[1]: *** [Makefile:849: all] Error 2
make[1]: Leaving directory '/home/rafael2k/programs/devel/TLVC/cross/build/binutils-build'
make: *** [Makefile:54: /home/rafael2k/programs/devel/TLVC/cross/build/.binutils.build] Error 2
make: Leaving directory '/home/rafael2k/programs/devel/TLVC/tools'
Build script has terminated with error 1

[rafael2k]

ps: with gcc 12 everything seems to compiles fine (I'm waiting for the build of the toolchain to finish).

[rafael2k]

With gcc 12 compilation goes until:

ia16-elf-gcc -ffreestanding -fno-inline -melks -mcmodel=small -msegment-relocation-stuff   -I/root/TLVC/include -I/root/TLVC/tlvc/include -I/root/TLVC/libc/include -D__KERNEL__ -Os -fno-delete-null-pointer-checks -Wnull-dereference -Wall -W -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wredundant-decls -Wuninitialized -Winline -Wswitch -Wshadow -Wchar-subscripts -Wwrite-strings -Wdiscarded-qualifiers -Wcast-align -Wcast-qual -Wno-sign-compare -Wno-cast-qual -Wno-unused-parameter -Wno-missing-prototypes -Wno-empty-body -c -o bioshd.o bioshd.c
bioshd.c:787:5: error: ‘bios_ioctl’ undeclared here (not in a function)
     bios_ioctl,   /* ioctl */
     ^~~~~~~~~~
bioshd.c: In function ‘bioshd_init’:
bioshd.c:845:19: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     char *p_sep = "";
                   ^~
bioshd.c:849:11: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     p_sep = "- ";
           ^
make[3]: *** [../../../../Makefile-rules:260: bioshd.o] Error 1
make[3]: Leaving directory '/root/TLVC/tlvc/arch/i86/drivers/block'
make[2]: *** [Makefile:195: drivers/block/blk_drv.a] Error 2
make[2]: Leaving directory '/root/TLVC/tlvc/arch/i86'
make[1]: *** [Makefile:75: Image] Error 2
make[1]: Leaving directory '/root/TLVC/tlvc'
make: *** [Makefile:13: all] Error 2
Build script has terminated with error 5

May be it is a bad ".config" setup?

[rafael2k]

My config:

#
# Automatically generated by make menuconfig: don't edit.
#


#
# Kernel & Hardware
#


#
# System
#

CONFIG_ARCH_IBMPC=y
# CONFIG_ARCH_8018X is not set
# CONFIG_ARCH_PC98 is not set
# CONFIG_HW_COMPAQFAST is not set
# CONFIG_HW_MK88 is not set
CONFIG_HW_PCXT=y
# CONFIG_CALIBRATE_DELAY is not set
CONFIG_HW_VGA=y
CONFIG_HW_SERIAL_FIFO=y
CONFIG_APM=y

#
# Kernel settings
#

CONFIG_BOOTOPTS=y
CONFIG_CPU_USAGE=y
# CONFIG_TIME_RTC_LOCALTIME is not set
# CONFIG_TRACE is not set
# CONFIG_TIMER_INT0F is not set
# CONFIG_TIMER_INT1C is not set
# CONFIG_ROMCODE is not set
CONFIG_FARTEXT_KERNEL=y

#
# Networking Support
#

CONFIG_SOCKET=y
# CONFIG_NANO is not set
CONFIG_INET=y
# CONFIG_UNIX is not set

#
# Filesystem Support
#

CONFIG_MINIX_FS=y
# CONFIG_ROMFS_FS is not set
CONFIG_FS_FAT=y
CONFIG_FS_DEV=y
# CONFIG_ROOT_READONLY is not set
# CONFIG_FS_RO is not set
CONFIG_FULL_VFS=y
CONFIG_32BIT_INODES=y
CONFIG_FS_EXTERNAL_BUFFER=y
CONFIG_FS_NR_EXT_BUFFERS=64
# CONFIG_FS_XMS_BUFFER is not set
CONFIG_PIPE=y
CONFIG_EXEC_COMPRESS=y
CONFIG_EXEC_MMODEL=y
CONFIG_EXEC_MMODEL=y

#
# Drivers
#


#
# Block device drivers
#

# CONFIG_BLK_DEV_DIRECT is not set
CONFIG_BLK_DEV_BIOS=y
CONFIG_BLK_DEV_BFD=y
CONFIG_BLK_DEV_BHD=y
# CONFIG_IDE_PROBE is not set
# CONFIG_DMA is not set
CONFIG_FLOPPY_CACHE=5
CONFIG_BLK_DEV_RAM=y
CONFIG_RAMDISK_SEGMENT=0
CONFIG_RAMDISK_SECTORS=128
CONFIG_BLK_DEV_SSD_NONE=y
# CONFIG_BLK_DEV_SSD_TEST is not set
# CONFIG_BLK_DEV_SSD_SD8018X is not set

#
# Character device drivers
#

CONFIG_CONSOLE_DIRECT=y
# CONFIG_CONSOLE_BIOS is not set
# CONFIG_CONSOLE_8018X is not set
# CONFIG_CONSOLE_HEADLESS is not set
CONFIG_KEYBOARD_SCANCODE=y
# CONFIG_CONSOLE_SERIAL is not set
CONFIG_EMUL_ANSI=y
# CONFIG_EMUL_VT52 is not set
# CONFIG_EMUL_NONE is not set
# CONFIG_EMUL_ANSI_PRINTK is not set
# CONFIG_KEYMAP_BE is not set
# CONFIG_KEYMAP_DE is not set
# CONFIG_KEYMAP_DV is not set
# CONFIG_KEYMAP_ES is not set
# CONFIG_KEYMAP_FR is not set
# CONFIG_KEYMAP_IT is not set
# CONFIG_KEYMAP_SE is not set
# CONFIG_KEYMAP_UK is not set
CONFIG_KEYMAP_US=y
CONFIG_CHAR_DEV_RS=y
# CONFIG_CHAR_DEV_LP is not set
# CONFIG_CHAR_DEV_CGATEXT is not set
CONFIG_CHAR_DEV_MEM=y
# CONFIG_CHAR_DEV_MEM_PORT_READ is not set
# CONFIG_CHAR_DEV_MEM_PORT_WRITE is not set
CONFIG_PSEUDO_TTY=y
# CONFIG_DEV_META is not set

#
# Network device drivers
#

CONFIG_ETH=y
CONFIG_ETH_NE2K=y
# CONFIG_ETH_WD is not set
# CONFIG_ETH_EL3 is not set
# CONFIG_ETH_EE16 is not set
# CONFIG_ETH_LANCE is not set

#
# Userland
#

# CONFIG_APPS_BY_IMAGESZ is not set
CONFIG_APP_ASH=y
CONFIG_APP_SASH=y
CONFIG_APP_DISK_UTILS=y
CONFIG_APP_FILE_UTILS=y
CONFIG_APP_SH_UTILS=y
CONFIG_APP_SYS_UTILS=y
CONFIG_APP_ELVIS=y
CONFIG_APP_MINIX1=y
CONFIG_APP_MINIX2=y
CONFIG_APP_MINIX3=y
CONFIG_APP_MISC_UTILS=y
CONFIG_APP_TUI=y
CONFIG_APP_NANOX=y
CONFIG_APP_BASIC=y
CONFIG_APP_SCREEN=y
CONFIG_APP_CRON=y
# CONFIG_APP_OTHER is not set
# CONFIG_APP_TEST is not set
# CONFIG_APP_BUSYELKS is not set
# CONFIG_APP_CGATEXT is not set
CONFIG_APP_KTCP=y
# CONFIG_APP_MAN_PAGES is not set
# CONFIG_SYS_DEFSHELL_SASH is not set
# CONFIG_SYS_NO_BININIT is not set

#
# Target image
#

CONFIG_IMG_MINIX=y
# CONFIG_IMG_FAT is not set
# CONFIG_IMG_RAW is not set
# CONFIG_IMG_ROM is not set
# CONFIG_IMG_FD2880 is not set
CONFIG_IMG_FD1440=y
# CONFIG_IMG_FD1232 is not set
# CONFIG_IMG_FD1200 is not set
# CONFIG_IMG_FD720 is not set
# CONFIG_IMG_FD360 is not set
# CONFIG_IMG_HD is not set
CONFIG_IMG_DEV=y
CONFIG_IMG_BOOT=y
# CONFIG_APPS_COMPRESS is not set
# CONFIG_IMG_EXTRA_IMAGES is not set

[Mellvik]

Thanks Rafael, there is a typo in the bioshd.c file. Apparently lack of testing (I'm hardly ever using BIOS IO for anything, that's one of the key purposes of TLVC, so BIOS support is maintained for testing and compatibility). No excuse though.

If you comment out the #define INCLUDE_RAW statement, you're fine for now. I'll push a fix later.
Or you can just skip BIOS disk/floppy and use the direct drivers instead.

[rafael2k]

Thanks @Mellvik. I use this setup as my Thinkpad does not do well with direct hd access in ELKS, so I basically copied the setup I use.

[rafael2k]

Thanks @Mellvik! Later today I'll test and report back concerning networks tests.

[Mellvik]

I understand @rafael2k. Note though that ELKS never had a working directhd driver which should explain your problems. In TLVC, directhdand directfd are the reliable choices since bioshd is rarely used (as you noticed).

Thanks for finding and reporting the problem.

[rafael2k]

Ooops, I wanted to say "IDE harddisk CHS probe" option, which I leave disabled on ELKS, as it does not do well with very large disks.

Cheers and thanks for TLVC!
: )

[Mellvik]

Ooops, I wanted to say "IDE harddisk CHS probe" option, which I leave disabled on ELKS, as it does not do well with very large disks.

I can imagine - did you create a bug report on that? I'd be interested in fixing it. BTW how large is 'very large'?

[rafael2k]

Ooops, I wanted to say "IDE harddisk CHS probe" option, which I leave disabled on ELKS, as it does not do well with very large disks.

I can imagine - did you create a bug report on that? I'd be interested in fixing it. BTW how large is 'very large'?

A 2TB disk. ELKS is the first partition, and works fine (after disabling this option).

ps: I did not create a issue about it, just about how to get ELKS running on my Thinkpad.

[Mellvik]

That's a big disk indeed. If you have the time, it would be helpful if you could enable CONFIG_IEQ_QUERY and, in the file idequery.c, enable IDE_DEBUG. It may not boot but it will print the content of the IDE data on the drive, which is what is causing it to fail.

Having that data available, I can fix the query so it works with all sizes and @ghaerr may take the changes back to ELKS (or you can do it).

Thank you.

[Mellvik]

As to the build issue, I'll look into that. It's interesting that the behaviour is different between two versions of gcc.

[rafael2k]

That's a big disk indeed. If you have the time, it would be helpful if you could enable CONFIG_IEQ_QUERY and, in the file idequery.c, enable IDE_DEBUG. It may not boot but it will print the content of the IDE data on the drive, which is what is causing it to fail.

I'll do it, thanks!