Refactor app delivery code

Author: Withalion

.github/workflows/app_delivery.yml

@@ -42,9 +42,7 @@ jobs:
             
             for (const workflowName of buildWorkflowNames) {
               // Filter to find the run matching the exact workflow name
-              const latestRun = runsResponse.data.workflow_runs.find(run => 
-                run.name === workflowName && run.conclusion === 'success'
-              );
+              const latestRun = runsResponse.data.workflow_runs.find(run => run.name === workflowName);
             
               if (!latestRun) {
                 console.log(`Could not find a successful run for workflow: ${workflowName}`);
@@ -72,18 +70,16 @@ jobs:
                   commentBody += `### ${workflowName} (Run #${latestRun.run_number})\n`;
               
                   for (const artifact of artifacts) {
-                    commentBody += `|**${workflowName}**| 📬 | [**${artifact.name}**](${artifact.archive_download_url}) | (Expires: ${new Date(artifact.expires_at).toLocaleDateString()}) | [#${latestRun.run_number}](${latestRun.html_url}) |\n`;
+                    commentBody += `|**${workflowName}**| 📬 | [**${artifact.name}**](${artifact.archive_download_url}) | Expires: ${new Date(artifact.expires_at).toLocaleDateString('en-GB')} | [#${latestRun.run_number}](${latestRun.html_url}) |\n`;
                     artifactsFound = true;
                   }
                 }
               } else {
-                if (latestRun.conclusion) {
-                  const currentYear = String(new Date().getFullYear()).slice(-2)
-                  const currentMonth = (new Date().getMonth() + 1).toLocaleString('en-US', {minimumIntegerDigits: 2, useGrouping:false})
-                  const buildId = `${latestRun.run_number}1${latestRun.run_attempt}`
-                  commentBody += `|**${workflowName}**| 📬 |  | Build number: ${currentYear}.${currentMonth}.${buildId} | [#${latestRun.run_number}](${latestRun.html_url}) |\n`;
-                  artifactsFound = true;
-                }
+                const currentYear = String(new Date().getFullYear()).slice(-2)
+                const currentMonth = (new Date().getMonth() + 1).toLocaleString('en-US', {minimumIntegerDigits: 2, useGrouping:false})
+                const buildId = `${latestRun.run_number}1${latestRun.run_attempt}`
+                commentBody += `|**${workflowName}**| 📬 |  | Build number: ${currentYear}.${currentMonth}.${buildId} | [#${latestRun.run_number}](${latestRun.html_url}) |\n`;
+                artifactsFound = true;
               }
             }