feat(transport): add rate limiting for messages and connections #776
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
|
|
||
| import { isResourceLimitError } from './isResourceLimitError.ts'; | ||
| import { ResourceLimitError } from '../errors/ResourceLimitError.ts'; | ||
|
|
||
| describe('isResourceLimitError', () => { | ||
| describe('without limitType parameter', () => { | ||
| it('returns true for ResourceLimitError', () => { | ||
| const error = new ResourceLimitError('limit exceeded'); | ||
| expect(isResourceLimitError(error)).toBe(true); | ||
| }); | ||
|
|
||
| it('returns true for ResourceLimitError with any limitType', () => { | ||
| const connectionError = new ResourceLimitError('connection limit', { | ||
| data: { limitType: 'connection' }, | ||
| }); | ||
| const rateError = new ResourceLimitError('rate limit', { | ||
| data: { limitType: 'connectionRate' }, | ||
| }); | ||
|
|
||
| expect(isResourceLimitError(connectionError)).toBe(true); | ||
| expect(isResourceLimitError(rateError)).toBe(true); | ||
| }); | ||
|
|
||
| it('returns false for regular Error', () => { | ||
| const error = new Error('some error'); | ||
| expect(isResourceLimitError(error)).toBe(false); | ||
| }); | ||
|
|
||
| it('returns false for null', () => { | ||
| expect(isResourceLimitError(null)).toBe(false); | ||
| }); | ||
|
|
||
| it('returns false for undefined', () => { | ||
| expect(isResourceLimitError(undefined)).toBe(false); | ||
| }); | ||
|
|
||
| it('returns false for non-error objects', () => { | ||
| expect(isResourceLimitError({ message: 'fake error' })).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('with limitType parameter', () => { | ||
| it('returns true when limitType matches', () => { | ||
| const error = new ResourceLimitError('connection limit', { | ||
| data: { limitType: 'connection' }, | ||
| }); | ||
| expect(isResourceLimitError(error, 'connection')).toBe(true); | ||
| }); | ||
|
|
||
| it('returns false when limitType does not match', () => { | ||
| const error = new ResourceLimitError('connection limit', { | ||
| data: { limitType: 'connection' }, | ||
| }); | ||
| expect(isResourceLimitError(error, 'connectionRate')).toBe(false); | ||
| }); | ||
|
|
||
| it('returns false when error has no limitType', () => { | ||
| const error = new ResourceLimitError('limit exceeded'); | ||
| expect(isResourceLimitError(error, 'connection')).toBe(false); | ||
| }); | ||
|
|
||
| it('returns false for non-ResourceLimitError even with matching-like data', () => { | ||
| const error = new Error('some error'); | ||
| expect(isResourceLimitError(error, 'connection')).toBe(false); | ||
| }); | ||
|
|
||
| it.each([ | ||
| 'connection', | ||
| 'connectionRate', | ||
| 'messageSize', | ||
| 'messageRate', | ||
| ] as const)('correctly identifies %s limitType', (limitType) => { | ||
| const error = new ResourceLimitError('limit exceeded', { | ||
| data: { limitType }, | ||
| }); | ||
| expect(isResourceLimitError(error, limitType)).toBe(true); | ||
| }); | ||
| }); | ||
| }); | ||
|
Comment on lines
+6
to
+80
Contributor
There was a problem hiding this comment. LG in this PR. This whole suite tests
Contributor
Author
There was a problem hiding this comment. I think its ok, not that difficult to read |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { ResourceLimitError } from '../errors/ResourceLimitError.ts'; | ||
| import type { | ||
| ResourceLimitType, | ||
| ResourceLimitErrorData, | ||
| } from '../errors/ResourceLimitError.ts'; | ||
|
|
||
| /** | ||
| * Check if an error is a ResourceLimitError, optionally with a specific limit type. | ||
| * | ||
| * @param error - The error to check. | ||
| * @param limitType - Optional limit type to match against. | ||
| * @returns True if the error is a ResourceLimitError (with matching limitType if specified). | ||
| */ | ||
| export function isResourceLimitError( | ||
| error: unknown, | ||
| limitType?: ResourceLimitType, | ||
| ): error is ResourceLimitError { | ||
| if (!(error instanceof ResourceLimitError)) { | ||
| return false; | ||
| } | ||
|
|
||
| if (limitType === undefined) { | ||
| return true; | ||
| } | ||
|
|
||
| const data = error.data as ResourceLimitErrorData | undefined; | ||
| return data?.limitType === limitType; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.